Format Firestore source code with clang-format (#477)

Author: dconeybe

firestore/.clang-format

@@ -6,5 +6,4 @@ AllowAllParametersOfDeclarationOnNextLine: true
 SpacesInContainerLiterals: true
 DerivePointerAlignment: false
 PointerAlignment: Left
-AllowShortFunctionsOnASingleLine: None
 IncludeBlocks: Preserve

firestore/src/android/blob_android.cc

@@ -34,7 +34,8 @@ void BlobInternal::Initialize(jni::Loader& loader) {
 
 Class BlobInternal::GetClass() { return Class(g_class); }
 
-Local<BlobInternal> BlobInternal::Create(Env& env, const uint8_t* value,
+Local<BlobInternal> BlobInternal::Create(Env& env,
+                                         const uint8_t* value,
                                          size_t size) {
   Local<Array<uint8_t>> byte_array = env.NewArray<uint8_t>(size);
   env.SetArrayRegion(byte_array, 0, size, value);

firestore/src/android/blob_android.h

@@ -15,7 +15,8 @@ class BlobInternal : public jni::Object {
 
   static jni::Class GetClass();
 
-  static jni::Local<BlobInternal> Create(jni::Env& env, const uint8_t* value,
+  static jni::Local<BlobInternal> Create(jni::Env& env,
+                                         const uint8_t* value,
                                          size_t size);
 
   jni::Local<jni::Array<uint8_t>> ToBytes(jni::Env& env) const;

firestore/src/android/converter_android.h

@@ -32,7 +32,8 @@ struct ConverterImpl {
   }
 
   template <typename PublicT, typename InternalT = InternalType<PublicT>>
-  static PublicT MakePublicFromJava(jni::Env& env, FirestoreInternal* firestore,
+  static PublicT MakePublicFromJava(jni::Env& env,
+                                    FirestoreInternal* firestore,
                                     const jni::Object& object) {
     if (!env.ok() || !object) return {};
 
@@ -62,7 +63,8 @@ PublicT MakePublic(jni::Env& env, const jni::Object& object) {
 }
 
 template <typename PublicT, typename InternalT = InternalType<PublicT>>
-PublicT MakePublic(jni::Env& env, FirestoreInternal* firestore,
+PublicT MakePublic(jni::Env& env,
+                   FirestoreInternal* firestore,
                    const jni::Object& object) {
   return ConverterImpl::MakePublicFromJava<PublicT, InternalT>(env, firestore,
                                                                object);

firestore/src/android/document_reference_android.cc

@@ -176,7 +176,8 @@ ListenerRegistration DocumentReferenceInternal::AddSnapshotListener(
 #endif  // defined(FIREBASE_USE_STD_FUNCTION)
 
 ListenerRegistration DocumentReferenceInternal::AddSnapshotListener(
-    MetadataChanges metadata_changes, EventListener<DocumentSnapshot>* listener,
+    MetadataChanges metadata_changes,
+    EventListener<DocumentSnapshot>* listener,
     bool passing_listener_ownership) {
   Env env = GetEnv();
   Local<Object> java_metadata =

firestore/src/android/exception_android.cc

@@ -98,7 +98,8 @@ std::string ExceptionInternal::ToString(Env& env, const Object& exception) {
   return exception.CastTo<Throwable>().GetMessage(env);
 }
 
-Local<Throwable> ExceptionInternal::Create(Env& env, Error code,
+Local<Throwable> ExceptionInternal::Create(Env& env,
+                                           Error code,
                                            const std::string& message) {
   if (code == Error::kErrorOk) {
     return {};

firestore/src/android/exception_android.h

@@ -21,7 +21,8 @@ class ExceptionInternal {
   static Error GetErrorCode(jni::Env& env, const jni::Object& exception);
   static std::string ToString(jni::Env& env, const jni::Object& exception);
 
-  static jni::Local<jni::Throwable> Create(jni::Env& env, Error code,
+  static jni::Local<jni::Throwable> Create(jni::Env& env,
+                                           Error code,
                                            const std::string& message);
   static jni::Local<jni::Throwable> Wrap(
       jni::Env& env, jni::Local<jni::Throwable>&& exception);

firestore/src/android/field_value_android.cc

@@ -71,7 +71,8 @@ FieldValue FieldValueInternal::Create(Env& env, const Object& object) {
   return FieldValue(new FieldValueInternal(Type::kNull, object));
 }
 
-FieldValue FieldValueInternal::Create(Env& env, Type type,
+FieldValue FieldValueInternal::Create(Env& env,
+                                      Type type,
                                       const Object& object) {
   if (!env.ok() || !object) return {};
   return FieldValue(new FieldValueInternal(type, object));

firestore/src/android/firestore_android.h

@@ -65,25 +65,17 @@ class FirestoreInternal {
   explicit FirestoreInternal(App* app);
   ~FirestoreInternal();
 
-  App* app() const {
-    return app_;
-  }
+  App* app() const { return app_; }
 
   // Whether this object was successfully initialized by the constructor.
-  bool initialized() const {
-    return app_ != nullptr;
-  }
+  bool initialized() const { return app_ != nullptr; }
 
   // Manages all Future objects returned from Firestore API.
-  FutureManager& future_manager() {
-    return future_manager_;
-  }
+  FutureManager& future_manager() { return future_manager_; }
 
   // When this is deleted, it will clean up all DatabaseReferences,
   // DataSnapshots, and other such objects.
-  CleanupNotifier& cleanup() {
-    return cleanup_;
-  }
+  CleanupNotifier& cleanup() { return cleanup_; }
 
   // Returns a CollectionReference that refers to the specific path.
   CollectionReference Collection(const char* collection_path) const;
@@ -159,12 +151,8 @@ class FirestoreInternal {
     firestore_public_ = firestore_public;
   }
 
-  Firestore* firestore_public() {
-    return firestore_public_;
-  }
-  const Firestore* firestore_public() const {
-    return firestore_public_;
-  }
+  Firestore* firestore_public() { return firestore_public_; }
+  const Firestore* firestore_public() const { return firestore_public_; }
 
   /**
    * Finds the FirestoreInternal instance for the given Java Firestore instance.

firestore/src/android/lambda_event_listener.h

@@ -24,7 +24,8 @@ class LambdaEventListener : public EventListener<T> {
     FIREBASE_ASSERT(callback_);
   }
 
-  void OnEvent(const T& value, Error error_code,
+  void OnEvent(const T& value,
+               Error error_code,
                const std::string& error_message) override {
     callback_(value, error_code, error_message);
   }