Fix Windows boringssl build by disabling warning 4191. (#956)

* Try disabling warning 4191.

* Add additional warning to ignore to boringssl build.

* Fix patch to work cross-platform with Git.

Author: jonsimantov

cmake/external/boringssl.cmake

@@ -19,7 +19,7 @@ if(TARGET boringssl OR NOT DOWNLOAD_BORINGSSL)
 endif()
 
 set(patch_file 
-  ${CMAKE_CURRENT_LIST_DIR}/../../scripts/git/patches/boringssl/0001-disable-C4255-converting-empty-params-to-void.patch)
+  ${CMAKE_CURRENT_LIST_DIR}/../../scripts/git/patches/boringssl/0001-disable-warnings.patch)
 
 set(boringssl_commit_tag 83da28a68f32023fd3b95a8ae94991a07b1f6c62)
 

scripts/git/patches/boringssl/0001-disable-C4255-converting-empty-params-to-void.patch renamed to scripts/git/patches/boringssl/0001-disable-warnings.patch

@@ -1,25 +1,13 @@
-From 831806231dd360278dac2a37e3c3158420ad7bb3 Mon Sep 17 00:00:00 2001
-From: "google.com" <google.com>
-Date: Mon, 7 Jun 2021 13:57:27 -0400
-Subject: [PATCH] disable C4255 converting () to (void)
-
----
- src/CMakeLists.txt | 2 ++
- 1 file changed, 2 insertions(+)
-
-diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
-index b7f468fe6..48f61bfd8 100644
 --- a/src/CMakeLists.txt
 +++ b/src/CMakeLists.txt
-@@ -193,6 +193,8 @@ elseif(MSVC)
+@@ -193,6 +193,10 @@ elseif(MSVC)
                # possible loss of data
        "C4244" # 'function' : conversion from 'int' to 'uint8_t',
                # possible loss of data
 +      "C4255" # 'function' : no function prototype given: converting '()' to
 +              # '(void)'
++      "C4191" # 'operator/operation' : unsafe conversion from 'type of
++              # expression' to 'type required'
        "C4267" # conversion from 'size_t' to 'int', possible loss of data
        "C4371" # layout of class may have changed from a previous version of the
                # compiler due to better packing of member '...'
--- 
-2.32.0.rc1.229.g3e70b5a671-goog
-