Remove all the remaining traces of 163140650. (#513)

Author: ehsannas

firestore/src/android/field_value_android.cc

@@ -256,16 +256,7 @@ const uint8_t* FieldValueInternal::blob_value() const {
     return nullptr;
   }
 
-  if (cached_blob_->empty()) {
-    // The return value doesn't matter, but we can't return
-    // `&cached_blob->front()` because calling `front` on an empty vector is
-    // undefined behavior. When we drop support for STLPort, we can use `data`
-    // instead which is defined, even for empty vectors.
-    // TODO(b/163140650): remove this special case.
-    return nullptr;
-  }
-
-  return &(cached_blob_->front());
+  return cached_blob_->data();
 }
 
 size_t FieldValueInternal::blob_size() const {

firestore/src/android/util_android.h

@@ -33,11 +33,7 @@ std::vector<PublicT> MakePublicVector(jni::Env& env,
     jni::Local<jni::Object> element = from.Get(env, i);
 
     // Avoid creating a partially valid public object on failure.
-    //
-    // TODO(b/163140650): Use `return {}`
-    // Clang 5 with STLPort gives a "chosen constructor is explicit in
-    // copy-initialization" error because the default constructor is explicit.
-    if (!env.ok()) return std::vector<PublicT>();
+    if (!env.ok()) return {};
 
     // Use push_back because emplace_back requires a public constructor.
     result.push_back(MakePublic<PublicT>(env, firestore, element));

firestore/src/common/exception_common.h

@@ -18,9 +18,7 @@
 // For internal programming errors, including internal argument checking, use
 // HARD_ASSERT or HARD_FAIL().
 //
-// TODO(b/163140650): Remove this/unify with the iOS implementation.
-// On Android we still support customers building with STLPort, which precludes
-// use of Abseil here.
+// TODO(b/191981857): Remove this/unify with the iOS implementation.
 
 #include <string>
 

firestore/src/common/macros.h

@@ -8,7 +8,7 @@
 // A collection of macros that really should come from elsewhere but are
 // required for compatibility with STLPort.
 //
-// TODO(b/163140650): Remove these and just use the Abseil equivalents.
+// TODO(b/191981857): Remove these and just use the Abseil equivalents.
 
 #if !defined(__ANDROID__)
 #include "absl/base/attributes.h"
@@ -25,7 +25,7 @@
 //
 // Discover if exceptions are enabled and define them as needed.
 //
-// TODO(b/163140650): Consider ABSL_HAVE_EXCEPTIONS after dropping STLPort.
+// TODO(b/191981857): Consider using ABSL_HAVE_EXCEPTIONS.
 // This will require re-validating the results of `GetFullCompilerInfo()` on all
 // supported platforms.
 #if defined(__clang__)

firestore/src/common/settings.cc

@@ -21,8 +21,7 @@ const char kDefaultHost[] = "firestore.googleapis.com";
 std::string ToStr(bool v) { return v ? "true" : "false"; }
 
 std::string ToStr(int64_t v) {
-  // TODO(b/163140650): use `std::to_string` (which will make this function
-  // unnecessary).
+  // TODO(b/192885139): when possible, use `std::to_string` instead.
   std::ostringstream s;
   s << v;
   return s.str();