Address control reaches end of non-void function warning

wilhuff · a-maurice · commit b1b5b0360e98 · 2020-03-11T18:05:46.000-07:00
firestore/src/common/field_value.cc: In member function ‘std::string firebase::firestore::FieldValue::ToString() const’:
firestore/src/common/field_value.cc:341:1: warning: control reaches end of non-void function [-Wreturn-type]
  341 | }

PiperOrigin-RevId: 299217768
diff --git a/firestore/src/common/field_value.cc b/firestore/src/common/field_value.cc
@@ -336,8 +336,9 @@ std::string FieldValue::ToString() const {
              ValueToString(integer_increment_value()) + ")";
   }
 
-  FIREBASE_ASSERT_MESSAGE(false, "Unexpected FieldValue type: %d",
-                          static_cast<int>(type()));
+  FIREBASE_ASSERT_MESSAGE_RETURN("<invalid>", false,
+                                 "Unexpected FieldValue type: %d",
+                                 static_cast<int>(type()));
 }
 
 bool operator==(const FieldValue& lhs, const FieldValue& rhs) {

Original file line number	Diff line number	Diff line change
`@@ -336,8 +336,9 @@ std::string FieldValue::ToString() const {`
`336`	`336`	`ValueToString(integer_increment_value()) + ")";`
`337`	`337`	`}`
`338`	`338`
`339`		`- FIREBASE_ASSERT_MESSAGE(false, "Unexpected FieldValue type: %d",`
`340`		`- static_cast<int>(type()));`
	`339`	`+ FIREBASE_ASSERT_MESSAGE_RETURN("<invalid>", false,`
	`340`	`+ "Unexpected FieldValue type: %d",`
	`341`	`+ static_cast<int>(type()));`
`341`	`342`	`}`
`342`	`343`
`343`	`344`	`bool operator==(const FieldValue& lhs, const FieldValue& rhs) {`