Skip to content

Commit b0fe3b7

Browse files
committed
linux and mac strings cmd does not recognize flag.
-accepteula works just on Windows. Linux/Mac runners are hanging indefinitely when this flag is supplied. Took it out from gradle and instead added a "dummy" step in workflow to just accept the license.
1 parent 70d4171 commit b0fe3b7

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

.github/workflows/android.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,17 @@ jobs:
9393
# Make sure to prepend the one in our repo root to the path.
9494
echo "${{ github.workspace }}" >> $GITHUB_PATH
9595
96+
- name: Run strings.exe once to accept license(Windows only)
97+
if: startsWith(matrix.os, 'windows')
98+
continue-on-error: true
99+
shell: bash
100+
run: |
101+
# This invocation is just to accept the license. Otherwise the command
102+
# fails during build process. Also, running a command with just this
103+
# flag makes the process exit with code 127 and stops the workflow.
104+
# We ignore the error and continue with the rest of the steps.
105+
strings -accepteula
106+
96107
- name: Cache ccache files
97108
id: cache_ccache
98109
uses: actions/cache@v2

android_build_files/generate_proguard.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ def generateCppProguard(File library, String outCppPro) {
2020
def stringsOutStream = new ByteArrayOutputStream()
2121
exec {
2222
executable 'strings'
23-
args "-accepteula", "$library"
23+
args "$library"
2424
standardOutput = stringsOutStream
2525
}
2626

0 commit comments

Comments
 (0)