Fix App Check on 32 bit desktop (#1341)

a-maurice · web-flow · commit a996724f089e · 2023-06-07T00:48:59.000Z
diff --git a/app_check/src/desktop/app_check_desktop.cc b/app_check/src/desktop/app_check_desktop.cc
@@ -53,8 +53,9 @@ ReferenceCountedFutureImpl* AppCheckInternal::future() {
 }
 
 bool AppCheckInternal::HasValidCacheToken() const {
-  // Get the current time, in milliseconds
-  int64_t current_time = std::time(nullptr) * 1000;
+  // Get the current time, in milliseconds (Done in two lines because of x86)
+  int64_t current_time = std::time(nullptr);
+  current_time *= 1000;
   // TODO(amaurice): Add some additional time to the check
   return cached_token_.expire_time_millis > current_time;
 }
diff --git a/release_build_files/readme.md b/release_build_files/readme.md
@@ -629,6 +629,7 @@ code.
 ## Release Notes
 ### Upcoming Release
 -   Changes
+    - App Check (Desktop): Fixed expired tokens being cached on 32-bit systems.
     - Remote Config (Desktop): Fixed handling of time zones on Windows when the
       time zone name in the current system language contains an accented
       character or apostrophe. This adds a requirement for applications using

Original file line number	Diff line number	Diff line change
`@@ -53,8 +53,9 @@ ReferenceCountedFutureImpl* AppCheckInternal::future() {`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`bool AppCheckInternal::HasValidCacheToken() const {`
`56`		`- // Get the current time, in milliseconds`
`57`		`- int64_t current_time = std::time(nullptr) * 1000;`
	`56`	`+ // Get the current time, in milliseconds (Done in two lines because of x86)`
	`57`	`+ int64_t current_time = std::time(nullptr);`
	`58`	`+ current_time *= 1000;`
`58`	`59`	`// TODO(amaurice): Add some additional time to the check`
`59`	`60`	`return cached_token_.expire_time_millis > current_time;`
`60`	`61`	`}`