Clang-tidy and common typo fixes (#1209)

Author: berile

app/src/util_ios.h

@@ -313,7 +313,7 @@ class ClassMethodImplementationCache {
   // indexed by selector name with each element that referencing a dictionary
   // of potential names for the selector that contains the original method
   // implementation on the class.
-  // i.e
+  // i.e.
   // selector_implementation_names_dict = dict[original_selector_name];
   NSMutableDictionary *selector_implementation_names_per_selector_;
 

gma/integration_test/src/integration_test.cc

@@ -1050,7 +1050,7 @@ TEST_F(FirebaseGmaUITest, TestRewardedAdLoadAndShow) {
     LogDebug("Waiting for a moment to ensure all callbacks are recorded.");
     app_framework::ProcessEvents(2000);
 
-    // If not running the UI test in CI (running mannually), keep this check.
+    // If not running the UI test in CI (running manually), keep this check.
     // Else running the UI test in CI, skip this check.
     if (!ShouldRunUITests()) {
       EXPECT_EQ(content_listener.num_ad_clicked(), 1);

gma/src/android/ad_request_converter.cc

@@ -28,7 +28,6 @@
 
 #include "app/src/log.h"
 #include "app/src/util_android.h"
-#include "gma/gma_resources.h"
 #include "gma/src/android/gma_android.h"
 #include "gma/src/common/gma_common.h"
 #include "gma/src/include/firebase/gma.h"

gma/src/android/ad_request_converter.h

@@ -32,7 +32,7 @@ namespace gma {
 /// AdRequest.
 /// @param[out] error kAdErrorCodeNone on success, or another error if
 /// problems occurred.
-/// @return On succes, a local reference to an Android object representing the
+/// @return On success, a local reference to an Android object representing the
 /// AdRequest, or nullptr on error.
 jobject GetJavaAdRequestFromCPPAdRequest(const AdRequest& request,
                                          gma::AdErrorCode* error);

gma/src/android/ad_view_internal_android.cc

@@ -25,7 +25,6 @@
 
 #include "app/src/assert.h"
 #include "app/src/util_android.h"
-#include "gma/gma_resources.h"
 #include "gma/src/android/ad_request_converter.h"
 #include "gma/src/android/gma_android.h"
 #include "gma/src/common/gma_common.h"
@@ -108,9 +107,9 @@ struct NulleryInvocationOnMainThreadData {
 
 AdViewInternalAndroid::AdViewInternalAndroid(AdView* base)
     : AdViewInternal(base),
+      destroyed_(false),
       helper_(nullptr),
-      initialized_(false),
-      destroyed_(false) {
+      initialized_(false) {
   firebase::MutexLock lock(mutex_);
 
   JNIEnv* env = ::firebase::gma::GetJNI();

gma/src/android/gma_android.cc

@@ -246,7 +246,7 @@ static AdapterInitializationStatus PopulateAdapterInitializationStatus(
 }
 
 // Initializes the Google Mobile Ads SDK using the MobileAds.initialize()
-// method. The GMA app ID is retreived from the App's android manifest.
+// method. The GMA app ID is retrieved from the App's android manifest.
 Future<AdapterInitializationStatus> InitializeGoogleMobileAds(JNIEnv* env) {
   Future<AdapterInitializationStatus> future_to_return;
   {
@@ -622,7 +622,6 @@ void CallOpenAdInspector(void* data) {
   OpenAdInspectorCallData* call_data =
       reinterpret_cast<OpenAdInspectorCallData*>(data);
   JNIEnv* env = firebase::util::GetThreadsafeJNIEnv(call_data->vm);
-  bool jni_env_exists = (env != nullptr);
   jlong jlistener = (jlong)call_data->listener;
 
   jobject ad_inspector_helper_ref = env->NewObject(
@@ -653,7 +652,7 @@ void OpenAdInspector(AdParent parent, AdInspectorClosedListener* listener) {
   call_data->ad_parent = env->NewGlobalRef(parent);
   call_data->listener = listener;
   jobject activity = ::firebase::gma::GetActivity();
-  util::RunOnMainThread(env, g_activity, CallOpenAdInspector, call_data);
+  util::RunOnMainThread(env, activity, CallOpenAdInspector, call_data);
 }
 
 void SetIsSameAppKeyEnabled(bool is_enabled) {}
@@ -816,8 +815,9 @@ AdValue::PrecisionType ConvertAndroidPrecisionTypeToCPPPrecisionType(
     default:
       LogWarning("Could not convert AdValue precisionType: %l",
                  j_precision_type);
+      return AdValue::kAdValuePrecisionUnknown;
     case 0:
-      return AdValue::kdValuePrecisionUnknown;
+      return AdValue::kAdValuePrecisionUnknown;
     case 1:  // ESTIMATED
       return AdValue::kAdValuePrecisionEstimated;
     case 2:  // PUBLISHER_PROVIDED
@@ -1216,10 +1216,10 @@ jobject CreateJavaAdSize(JNIEnv* env, jobject j_activity,
               ad_size::GetMethodId(
                   ad_size::kGetCurrentOrientationAnchoredAdaptiveBannerAdSize),
               j_activity, adsize.width());
-
+          break;
         default:
           FIREBASE_ASSERT_MESSAGE(true,
-                                  "Uknown Anchor Adaptive AdSize Orientation");
+                                  "Unknown Anchor Adaptive AdSize Orientation");
       }
       break;
     case AdSize::kTypeInlineAdaptive:
@@ -1253,7 +1253,7 @@ jobject CreateJavaAdSize(JNIEnv* env, jobject j_activity,
             break;
           default:
             FIREBASE_ASSERT_MESSAGE(
-                true, "Uknown Inline Adaptive AdSize Orientation");
+                true, "Unknown Inline Adaptive AdSize Orientation");
         }
       }
       break;
@@ -1263,7 +1263,7 @@ jobject CreateJavaAdSize(JNIEnv* env, jobject j_activity,
                                  adsize.width(), adsize.height());
       break;
     default:
-      FIREBASE_ASSERT_MESSAGE(true, "Uknown AdSize Type");
+      FIREBASE_ASSERT_MESSAGE(true, "Unknown AdSize Type");
   }
   bool jni_exception = util::CheckAndClearJniExceptions(env);
   FIREBASE_ASSERT(!jni_exception);

gma/src/android/gma_android.h

@@ -175,7 +175,7 @@ METHOD_LOOKUP_DECLARATION(gma_initialization_helper,
 // Needed when GMA is initialized without Firebase.
 JNIEnv* GetJNI();
 
-// Retrieves the activity used to initalize GMA.
+// Retrieves the activity used to initialize GMA.
 jobject GetActivity();
 
 // Register the native callbacks needed by the Futures.

gma/src/android/interstitial_ad_internal_android.cc

@@ -24,7 +24,6 @@
 
 #include "app/src/assert.h"
 #include "app/src/util_android.h"
-#include "gma/gma_resources.h"
 #include "gma/src/android/ad_request_converter.h"
 #include "gma/src/android/gma_android.h"
 #include "gma/src/common/gma_common.h"

gma/src/android/response_info_android.cc

@@ -51,7 +51,7 @@ ResponseInfo::ResponseInfo(const ResponseInfoInternal& response_info_internal) {
   const int list_size = (int)env->CallIntMethod(
       j_adapter_response_info_list, util::list::GetMethodId(util::list::kSize));
   for (int i = 0; i < list_size; ++i) {
-    // AdatperResponseInfo for this adapter.
+    // AdapterResponseInfo for this adapter.
     jobject j_adapter_response_info =
         env->CallObjectMethod(j_adapter_response_info_list,
                               util::list::GetMethodId(util::list::kGet), i);

gma/src/android/rewarded_ad_internal_android.cc

@@ -24,7 +24,6 @@
 
 #include "app/src/assert.h"
 #include "app/src/util_android.h"
-#include "gma/gma_resources.h"
 #include "gma/src/android/ad_request_converter.h"
 #include "gma/src/android/gma_android.h"
 #include "gma/src/common/gma_common.h"