Add the FIREBASE_PYTHON_EXECUTABLE cache variable to cmake (#478)

Author: dconeybe

CMakeLists.txt

@@ -81,6 +81,9 @@ if (NOT FIREBASE_ANDROID_STL STREQUAL "")
   set(ANDROID_STL ${FIREBASE_ANDROID_STL})
 endif()
 
+set(FIREBASE_PYTHON_EXECUTABLE "python" CACHE FILEPATH
+  "The Python interpreter to use, such as one from a venv")
+
 set(FIREBASE_XCODE_TARGET_FORMAT "frameworks" CACHE STRING
                                  "Format to output, 'frameworks' or 'libraries'")
 

admob/integration_test/CMakeLists.txt

@@ -16,6 +16,9 @@
 
 cmake_minimum_required(VERSION 2.8)
 
+set(FIREBASE_PYTHON_EXECUTABLE "python" CACHE FILEPATH
+  "The Python interpreter to use, such as one from a venv")
+
 # User settings for Firebase integration tests.
 # Path to Firebase SDK.
 # Try to read the path to the Firebase C++ SDK from an environment variable.
@@ -39,7 +42,7 @@ endif()
 if(NOT ANDROID)
   if (EXISTS ${CMAKE_CURRENT_LIST_DIR}/../../setup_integration_tests.py)
     # If this is running from inside the SDK directory, run the setup script.
-    execute_process(COMMAND "python" "${CMAKE_CURRENT_LIST_DIR}/../../setup_integration_tests.py" "${CMAKE_CURRENT_LIST_DIR}")
+    execute_process(COMMAND ${FIREBASE_PYTHON_EXECUTABLE} "${CMAKE_CURRENT_LIST_DIR}/../../setup_integration_tests.py" "${CMAKE_CURRENT_LIST_DIR}")
   endif()
 endif()
 

analytics/CMakeLists.txt

@@ -29,7 +29,7 @@ file(MAKE_DIRECTORY ${analytics_generated_headers_dir})
 function(generate_analytics_header OBJC_FILE CPP_FILE)
   add_custom_command(
     OUTPUT ${CPP_FILE}
-    COMMAND python "${CMAKE_CURRENT_LIST_DIR}/generate_constants.py"
+    COMMAND ${FIREBASE_PYTHON_EXECUTABLE} "${CMAKE_CURRENT_LIST_DIR}/generate_constants.py"
       "--objc_header=${OBJC_FILE}"
       "--cpp_header=${CPP_FILE}"
     DEPENDS ${OBJC_FILE}

analytics/integration_test/CMakeLists.txt

@@ -16,6 +16,9 @@
 
 cmake_minimum_required(VERSION 2.8)
 
+set(FIREBASE_PYTHON_EXECUTABLE "python" CACHE FILEPATH
+  "The Python interpreter to use, such as one from a venv")
+
 # User settings for Firebase integration tests.
 # Path to Firebase SDK.
 # Try to read the path to the Firebase C++ SDK from an environment variable.
@@ -39,7 +42,7 @@ endif()
 if(NOT ANDROID)
   if (EXISTS ${CMAKE_CURRENT_LIST_DIR}/../../setup_integration_tests.py)
     # If this is running from inside the SDK directory, run the setup script.
-    execute_process(COMMAND "python" "${CMAKE_CURRENT_LIST_DIR}/../../setup_integration_tests.py" "${CMAKE_CURRENT_LIST_DIR}")
+    execute_process(COMMAND ${FIREBASE_PYTHON_EXECUTABLE} "${CMAKE_CURRENT_LIST_DIR}/../../setup_integration_tests.py" "${CMAKE_CURRENT_LIST_DIR}")
   endif()
 endif()
 

app/CMakeLists.txt

@@ -46,7 +46,7 @@ set(version_header ${version_header_dir}/version.h)
 file(MAKE_DIRECTORY ${version_header_dir})
 add_custom_command(
     OUTPUT ${version_header}
-    COMMAND python "${FIREBASE_SCRIPT_DIR}/version_header.py"
+    COMMAND ${FIREBASE_PYTHON_EXECUTABLE} "${FIREBASE_SCRIPT_DIR}/version_header.py"
         "--input_file=${FIREBASE_SCRIPT_DIR}/cpp_sdk_version.json"
         "--output_file=${version_header}"
         "--build_type=released"
@@ -417,7 +417,7 @@ if (IOS)
   function(generate_analytics_header OBJC_FILE CPP_FILE)
     add_custom_command(
       OUTPUT ${CPP_FILE}
-      COMMAND python "${FIREBASE_SOURCE_DIR}/analytics/generate_constants.py"
+      COMMAND ${FIREBASE_PYTHON_EXECUTABLE} "${FIREBASE_SOURCE_DIR}/analytics/generate_constants.py"
         "--objc_header=${OBJC_FILE}"
         "--cpp_header=${CPP_FILE}"
       DEPENDS ${OBJC_FILE}

app/integration_test/CMakeLists.txt

@@ -16,6 +16,9 @@
 
 cmake_minimum_required(VERSION 2.8)
 
+set(FIREBASE_PYTHON_EXECUTABLE "python" CACHE FILEPATH
+  "The Python interpreter to use, such as one from a venv")
+
 # User settings for Firebase integration tests.
 # Path to Firebase SDK.
 # Try to read the path to the Firebase C++ SDK from an environment variable.
@@ -39,7 +42,7 @@ endif()
 if(NOT ANDROID)
   if (EXISTS ${CMAKE_CURRENT_LIST_DIR}/../../setup_integration_tests.py)
     # If this is running from inside the SDK directory, run the setup script.
-    execute_process(COMMAND "python" "${CMAKE_CURRENT_LIST_DIR}/../../setup_integration_tests.py" "${CMAKE_CURRENT_LIST_DIR}")
+    execute_process(COMMAND ${FIREBASE_PYTHON_EXECUTABLE} "${CMAKE_CURRENT_LIST_DIR}/../../setup_integration_tests.py" "${CMAKE_CURRENT_LIST_DIR}")
   endif()
 endif()
 

auth/integration_test/CMakeLists.txt

@@ -16,6 +16,9 @@
 
 cmake_minimum_required(VERSION 2.8)
 
+set(FIREBASE_PYTHON_EXECUTABLE "python" CACHE FILEPATH
+  "The Python interpreter to use, such as one from a venv")
+
 # User settings for Firebase integration tests.
 # Path to Firebase SDK.
 # Try to read the path to the Firebase C++ SDK from an environment variable.
@@ -39,7 +42,7 @@ endif()
 if(NOT ANDROID)
   if (EXISTS ${CMAKE_CURRENT_LIST_DIR}/../../setup_integration_tests.py)
     # If this is running from inside the SDK directory, run the setup script.
-    execute_process(COMMAND "python" "${CMAKE_CURRENT_LIST_DIR}/../../setup_integration_tests.py" "${CMAKE_CURRENT_LIST_DIR}")
+    execute_process(COMMAND ${FIREBASE_PYTHON_EXECUTABLE} "${CMAKE_CURRENT_LIST_DIR}/../../setup_integration_tests.py" "${CMAKE_CURRENT_LIST_DIR}")
   endif()
 endif()
 

cmake/binary_to_array.cmake

@@ -39,7 +39,7 @@ function(binary_to_array NAME INPUT CPP_NAMESPACE OUTPUT_DIRECTORY)
     OUTPUT ${output_source}
       ${output_header}
     DEPENDS ${INPUT}
-    COMMAND python "${FIREBASE_SCRIPT_DIR}/binary_to_array.py"
+    COMMAND ${FIREBASE_PYTHON_EXECUTABLE} "${FIREBASE_SCRIPT_DIR}/binary_to_array.py"
       "--input=${INPUT}"
       "--output_header=${output_header}"
       "--output_source=${output_source}"
@@ -49,4 +49,4 @@ function(binary_to_array NAME INPUT CPP_NAMESPACE OUTPUT_DIRECTORY)
       "--filename_identifier=${NAME}_filename"
     COMMENT "Generating ${NAME}"
   )
-endfunction()
+endfunction()

cmake/external_rules.cmake

@@ -123,7 +123,7 @@ function(download_external_sources)
     endif()
 
     execute_process(
-      COMMAND "python" "${PROJECT_SOURCE_DIR}/scripts/patch_websockets.py" 
+      COMMAND ${FIREBASE_PYTHON_EXECUTABLE} "${PROJECT_SOURCE_DIR}/scripts/patch_websockets.py" 
               "-file" "${PROJECT_BINARY_DIR}/external/src/uWebSockets/src/Socket.h"
               "-cmakefile" "${PROJECT_SOURCE_DIR}/cmake/external/uWebSockets.cmake" 
       RESULT_VARIABLE STATUS)

database/integration_test/CMakeLists.txt

@@ -16,6 +16,9 @@
 
 cmake_minimum_required(VERSION 2.8)
 
+set(FIREBASE_PYTHON_EXECUTABLE "python" CACHE FILEPATH
+  "The Python interpreter to use, such as one from a venv")
+
 # User settings for Firebase integration tests.
 # Path to Firebase SDK.
 # Try to read the path to the Firebase C++ SDK from an environment variable.
@@ -39,7 +42,7 @@ endif()
 if(NOT ANDROID)
   if (EXISTS ${CMAKE_CURRENT_LIST_DIR}/../../setup_integration_tests.py)
     # If this is running from inside the SDK directory, run the setup script.
-    execute_process(COMMAND "python" "${CMAKE_CURRENT_LIST_DIR}/../../setup_integration_tests.py" "${CMAKE_CURRENT_LIST_DIR}")
+    execute_process(COMMAND ${FIREBASE_PYTHON_EXECUTABLE} "${CMAKE_CURRENT_LIST_DIR}/../../setup_integration_tests.py" "${CMAKE_CURRENT_LIST_DIR}")
   endif()
 endif()