Fix UserSecureFakeInternal on Windows.

You can now force UserSecureFakeInternal on any platform by passing in
-DFORCE_FAKE_SECURE_STORAGE.

Also, because Windows and OS X don't have FLAGS_test_tmpdir, we now read the
TEST_TMPDIR from environment variables instead on all platforms.

PiperOrigin-RevId: 246402564

Author: jonsimantov

auth/src/desktop/secure/user_secure_fake_internal.cc

@@ -15,20 +15,35 @@
 #include "auth/src/desktop/secure/user_secure_fake_internal.h"
 
 #if defined(_WIN32)
+#include <direct.h>
 #include <windows.h>
 #else
 #include <dirent.h>
 #include <sys/stat.h>
 #include <sys/types.h>
 #endif  // defined(_WIN32)
 
+#include <errno.h>
+
 #include <cstdio>
 #include <fstream>
+#include <string>
 
 namespace firebase {
 namespace auth {
 namespace secure {
 
+#if defined(_WIN32)
+static const char kDirectorySeparator[] = "\\";
+#define unlink _unlink
+#define mkdir(x, y) _mkdir(x)
+#define rmdir _rmdir
+#else
+static const char kDirectorySeparator[] = "/";
+#endif  // defined(_WIN32)
+
+static const char kFileExtension[] = ".authbin";
+
 UserSecureFakeInternal::UserSecureFakeInternal(const char* secure_path)
     : secure_path_(secure_path) {}
 
@@ -41,11 +56,12 @@ std::string UserSecureFakeInternal::LoadUserData(const std::string& app_name) {
   std::ifstream infile;
   infile.open(filename, std::ios::binary);
   if (infile.fail()) {
+    LogDebug("LoadUserData: Failed to read %s", filename.c_str());
     return "";
   }
 
   infile.seekg(0, std::ios::end);
-  int64_t length = infile.tellg();
+  size_t length = infile.tellg();
   infile.seekg(0, std::ios::beg);
   output.resize(length);
   infile.read(&*output.begin(), length);
@@ -59,11 +75,13 @@ std::string UserSecureFakeInternal::LoadUserData(const std::string& app_name) {
 void UserSecureFakeInternal::SaveUserData(const std::string& app_name,
                                           const std::string& user_data) {
   // Make the directory in case it doesn't already exist, ignoring errors.
-#if defined(_WIN32)
-  CreateDirectory(secure_path_.c_str(), NULL);
-#else
-  mkdir(secure_path_.c_str(), 0700);
-#endif
+  if (mkdir(secure_path_.c_str(), 0700) < 0) {
+    int error = errno;
+    if (error != 0 && error != EEXIST) {
+      LogWarning("SaveUserData: Couldn't create directory %s: %d",
+                 secure_path_.c_str(), error);
+    }
+  }
 
   std::string filename = GetFilePath(app_name);
 
@@ -88,41 +106,68 @@ void UserSecureFakeInternal::DeleteUserData(const std::string& app_name) {
 }
 
 void UserSecureFakeInternal::DeleteAllData() {
+  std::vector<std::string> files_to_delete;
 #if defined(_WIN32)
+  std::string file_spec =
+      secure_path_ + kDirectorySeparator + "*" + kFileExtension;
   WIN32_FIND_DATA file_data;
-  HANDLE handle = FindFirstFile(secure_path_.c_str(), &file_data);
+  HANDLE handle = FindFirstFile(file_spec.c_str(), &file_data);
   if (INVALID_HANDLE_VALUE == handle) {
+    DWORD error = GetLastError();
+    if (error != ERROR_FILE_NOT_FOUND) {
+      LogWarning("DeleteAllData: Couldn't find file list matching %s: %d",
+                 file_spec.c_str(), error);
+    }
     return;
   }
-  DeleteFile(file_data.cFileName);
-  while (FindNextFile(handle, &file_data)) {
-    DeleteFile(file_data.cFileName);
-  }
+  do {
+    std::string file_path =
+        secure_path_ + kDirectorySeparator + file_data.cFileName;
+    files_to_delete.push_back(file_path);
+  } while (FindNextFile(handle, &file_data));
   FindClose(handle);
-  RemoveDirectory(secure_path_.c_str());
 #else
   // These are data types defined in the "dirent" header
-  DIR* theFolder = opendir(secure_path_.c_str());
-  if (!theFolder) {
+  DIR* the_folder = opendir(secure_path_.c_str());
+  if (!the_folder) {
     return;
   }
   struct dirent* next_file;
 
-  while ((next_file = readdir(theFolder)) != nullptr) {
-    // build the path for each file in the folder
-    std::string filepath = secure_path_ + "/";
-    filepath.append(next_file->d_name);
-    unlink(filepath.c_str());
+  while ((next_file = readdir(the_folder)) != nullptr) {
+    // Only delete files matching the file extension.
+    if (strcasestr(next_file->d_name, kFileExtension) !=
+        next_file->d_name + strlen(next_file->d_name) -
+            strlen(kFileExtension)) {
+      continue;
+    }
+    // Build the path for each file in the folder
+    std::string file_path =
+        secure_path_ + kDirectorySeparator + next_file->d_name;
+    files_to_delete.push_back(file_path);
   }
-  closedir(theFolder);
-
-  // Remove the directory if it's empty, ignoring errors.
-  rmdir(secure_path_.c_str());
+  closedir(the_folder);
 #endif
+  for (int i = 0; i < files_to_delete.size(); ++i) {
+    if (unlink(files_to_delete[i].c_str()) == -1) {
+      int error = errno;
+      if (error != 0) {
+        LogWarning("DeleteAllData: Couldn't remove file %s: %d",
+                   files_to_delete[i].c_str(), error);
+      }
+    }
+  }
+  // Remove the directory if it's empty, ignoring errors.
+  if (rmdir(secure_path_.c_str()) == -1) {
+    int error = errno;
+    LogDebug("DeleteAllData: Couldn't remove directory %s: %d",
+             secure_path_.c_str(), error);
+  }
 }
 
 std::string UserSecureFakeInternal::GetFilePath(const std::string& app_name) {
-  std::string filepath = secure_path_ + "/" + app_name + "_bin";
+  std::string filepath =
+      secure_path_ + kDirectorySeparator + app_name + kFileExtension;
   return filepath;
 }