Cleaned up some warnings that manifest on the open source build.

PiperOrigin-RevId: 311203902

Author: amablue

database/src/desktop/connection/persistent_connection.cc

@@ -238,7 +238,7 @@ void PersistentConnection::HandleConnectStatsResponse(
   if (status != kRequestStatusOk) {
     auto error = GetStringValue(message, kServerDataUpdateBody, true);
 
-    if (LogGetLevel() > kLogLevelInfo) {
+    if (GetLogLevel() > kLogLevelInfo) {
       logger_->LogDebug("%s Failed to send stats: %s  (message: %s)",
                         log_id_.c_str(), status.c_str(), error.c_str());
     }

database/src/desktop/core/indexed_variant.cc

@@ -17,6 +17,7 @@
 #include <algorithm>
 #include <cassert>
 
+#include "app/src/assert.h"
 #include "app/src/include/firebase/variant.h"
 #include "database/src/common/query_spec.h"
 #include "database/src/desktop/query_params_comparator.h"
@@ -113,6 +114,8 @@ const Variant* IndexedVariant::GetOrderByVariant(const Variant& key,
       return GetVariantValue(&value);
     }
   }
+  FIREBASE_DEV_ASSERT_MESSAGE(false, "Invalid QueryParams::OrderBy");
+  return nullptr;
 }
 
 static bool IsDefinedOn(const Variant& variant, const QueryParams& params) {

database/src/desktop/core/operation.cc

@@ -157,6 +157,8 @@ Optional<Operation> OperationForChild(const Operation& op,
       return OperationForChildListenComplete(op, child_key);
     }
   }
+  FIREBASE_DEV_ASSERT_MESSAGE(false, "Invalid Operation::Type");
+  return Optional<Operation>();
 }
 
 }  // namespace internal

database/src/desktop/query_params_comparator.cc

@@ -17,6 +17,7 @@
 #include <cassert>
 #include <cstdint>
 
+#include "app/src/assert.h"
 #include "app/src/util.h"
 #include "database/src/desktop/util_desktop.h"
 
@@ -91,6 +92,8 @@ int QueryParamsComparator::Compare(const Variant& key_a, const Variant& value_a,
       return result;
     }
   }
+  FIREBASE_DEV_ASSERT_MESSAGE(false, "Invalid QueryParams::OrderBy");
+  return 0;
 }
 
 int QueryParamsComparator::ComparePriorities(const Variant& value_a,

database/src/desktop/util_desktop.cc

@@ -1017,6 +1017,8 @@ std::pair<Variant, Variant> MakePost(const QueryParams& params,
       return std::make_pair(name, value);
     }
   }
+  FIREBASE_DEV_ASSERT_MESSAGE(false, "Invalid QueryParams::OrderBy");
+  return std::pair<Variant, Variant>();
 }
 
 bool HasStart(const QueryParams& params) {