Don't expose FooLastResult functions in the public C++ API.

Removing the implementation can be done in a follow-up.

PiperOrigin-RevId: 307659652

Author: var-const

firestore/src/common/collection_reference.cc

@@ -87,11 +87,6 @@ Future<DocumentReference> CollectionReference::Add(const MapFieldValue& data) {
   return internal()->Add(data);
 }
 
-Future<DocumentReference> CollectionReference::AddLastResult() const {
-  if (!internal()) return FailedFuture<DocumentReference>();
-  return internal()->AddLastResult();
-}
-
 CollectionReferenceInternal* CollectionReference::internal() const {
   return static_cast<CollectionReferenceInternal*>(internal_);
 }

firestore/src/common/document_reference.cc

@@ -130,22 +130,12 @@ Future<DocumentSnapshot> DocumentReference::Get(Source source) const {
   return internal_->Get(source);
 }
 
-Future<DocumentSnapshot> DocumentReference::GetLastResult() const {
-  if (!internal_) return FailedFuture<DocumentSnapshot>();
-  return internal_->GetLastResult();
-}
-
 Future<void> DocumentReference::Set(const MapFieldValue& data,
                                     const SetOptions& options) {
   if (!internal_) return FailedFuture<void>();
   return internal_->Set(data, options);
 }
 
-Future<void> DocumentReference::SetLastResult() const {
-  if (!internal_) return FailedFuture<void>();
-  return internal_->SetLastResult();
-}
-
 Future<void> DocumentReference::Update(const MapFieldValue& data) {
   if (!internal_) return FailedFuture<void>();
   return internal_->Update(data);
@@ -156,21 +146,11 @@ Future<void> DocumentReference::Update(const MapFieldPathValue& data) {
   return internal_->Update(data);
 }
 
-Future<void> DocumentReference::UpdateLastResult() const {
-  if (!internal_) return FailedFuture<void>();
-  return internal_->UpdateLastResult();
-}
-
 Future<void> DocumentReference::Delete() {
   if (!internal_) return FailedFuture<void>();
   return internal_->Delete();
 }
 
-Future<void> DocumentReference::DeleteLastResult() const {
-  if (!internal_) return FailedFuture<void>();
-  return internal_->DeleteLastResult();
-}
-
 #if defined(FIREBASE_USE_STD_FUNCTION) || defined(DOXYGEN)
 ListenerRegistration DocumentReference::AddSnapshotListener(
     std::function<void(const DocumentSnapshot&, Error)> callback) {

firestore/src/common/firestore.cc

@@ -237,62 +237,32 @@ Future<void> Firestore::RunTransaction(
 }
 #endif  // defined(FIREBASE_USE_STD_FUNCTION) || defined(DOXYGEN)
 
-Future<void> Firestore::RunTransactionLastResult() {
-  if (!internal_) return FailedFuture<void>();
-  return internal_->RunTransactionLastResult();
-}
-
 Future<void> Firestore::DisableNetwork() {
   if (!internal_) return FailedFuture<void>();
   return internal_->DisableNetwork();
 }
 
-Future<void> Firestore::DisableNetworkLastResult() {
-  if (!internal_) return FailedFuture<void>();
-  return internal_->DisableNetworkLastResult();
-}
-
 Future<void> Firestore::EnableNetwork() {
   if (!internal_) return FailedFuture<void>();
   return internal_->EnableNetwork();
 }
 
-Future<void> Firestore::EnableNetworkLastResult() {
-  if (!internal_) return FailedFuture<void>();
-  return internal_->EnableNetworkLastResult();
-}
-
 Future<void> Firestore::Terminate() {
   if (!internal_) return FailedFuture<void>();
   FirestoreCache()->erase(app());
   return internal_->Terminate();
 }
 
-Future<void> Firestore::TerminateLastResult() {
-  if (!internal_) return FailedFuture<void>();
-  return internal_->TerminateLastResult();
-}
-
 Future<void> Firestore::WaitForPendingWrites() {
   if (!internal_) return FailedFuture<void>();
   return internal_->WaitForPendingWrites();
 }
 
-Future<void> Firestore::WaitForPendingWritesLastResult() {
-  if (!internal_) return FailedFuture<void>();
-  return internal_->WaitForPendingWritesLastResult();
-}
-
 Future<void> Firestore::ClearPersistence() {
   if (!internal_) return FailedFuture<void>();
   return internal_->ClearPersistence();
 }
 
-Future<void> Firestore::ClearPersistenceLastResult() {
-  if (!internal_) return FailedFuture<void>();
-  return internal_->ClearPersistenceLastResult();
-}
-
 #if !defined(FIREBASE_USE_STD_FUNCTION) || defined(DOXYGEN)
 ListenerRegistration Firestore::AddSnapshotsInSyncListener(
     EventListener<void>* listener) {

firestore/src/common/query.cc

@@ -242,11 +242,6 @@ Future<QuerySnapshot> Query::Get(Source source) const {
   return internal_->Get(source);
 }
 
-Future<QuerySnapshot> Query::GetLastResult() const {
-  if (!internal_) return FailedFuture<QuerySnapshot>();
-  return internal_->GetLastResult();
-}
-
 #if defined(FIREBASE_USE_STD_FUNCTION) || defined(DOXYGEN)
 ListenerRegistration Query::AddSnapshotListener(
     std::function<void(const QuerySnapshot&, Error)> callback) {

firestore/src/common/write_batch.cc

@@ -110,10 +110,5 @@ Future<void> WriteBatch::Commit() {
   return internal_->Commit();
 }
 
-Future<void> WriteBatch::CommitLastResult() const {
-  if (!internal_) return FailedFuture<void>();
-  return internal_->CommitLastResult();
-}
-
 }  // namespace firestore
 }  // namespace firebase

firestore/src/include/firebase/firestore.h

@@ -266,9 +266,6 @@ class Firestore {
    */
   virtual Future<void> RunTransaction(TransactionFunction* update);
 
-  /** Gets the result of the most recent call to RunTransaction(). */
-  virtual Future<void> RunTransactionLastResult();
-
   /**
    * Sets the log verbosity of all Firestore instances.
    *
@@ -286,18 +283,12 @@ class Firestore {
    */
   virtual Future<void> DisableNetwork();
 
-  /** Gets the result of the most recent call to DisableNetwork(). */
-  Future<void> DisableNetworkLastResult();
-
   /**
    * Re-enables network usage for this instance after a prior call to
    * DisableNetwork().
    */
   virtual Future<void> EnableNetwork();
 
-  /** Gets the result of the most recent call to EnableNetwork(). */
-  Future<void> EnableNetworkLastResult();
-
   /**
    * Terminates this `Firestore` instance.
    *
@@ -322,9 +313,6 @@ class Firestore {
    */
   virtual Future<void> Terminate();
 
-  /** Gets the result of the most recent call to `Terminate()`. */
-  Future<void> TerminateLastResult();
-
   /**
    * Waits until all currently pending writes for the active user have been
    * acknowledged by the backend.
@@ -341,9 +329,6 @@ class Firestore {
    */
   virtual Future<void> WaitForPendingWrites();
 
-  /** Gets the result of the most recent call to WaitForPendingWrites(). */
-  Future<void> WaitForPendingWritesLastResult();
-
   /**
    * Clears the persistent storage. This includes pending writes and cached
    * documents.
@@ -363,9 +348,6 @@ class Firestore {
    */
   virtual Future<void> ClearPersistence();
 
-  /** Gets the result of the most recent call to ClearPersistence(). */
-  Future<void> ClearPersistenceLastResult();
-
 #if defined(FIREBASE_USE_STD_FUNCTION) || defined(DOXYGEN)
   /**
    * Attaches a listener for a snapshots-in-sync event. Server-generated

firestore/src/include/firebase/firestore/collection_reference.h

@@ -164,14 +164,6 @@ class CollectionReference : public Query {
    */
   virtual Future<DocumentReference> Add(const MapFieldValue& data);
 
-  /**
-   * @brief Gets the result of the most recent call to Add().
-   *
-   * @return The result of last call to Add() or an invalid Future, if there is
-   * no such call.
-   */
-  virtual Future<DocumentReference> AddLastResult() const;
-
  private:
   friend class DocumentReference;
   friend class DocumentReferenceInternal;

firestore/src/include/firebase/firestore/document_reference.h

@@ -200,14 +200,6 @@ class DocumentReference {
    */
   virtual Future<DocumentSnapshot> Get(Source source = Source::kDefault) const;
 
-  /**
-   * @brief Gets the result of the most recent call to the Get() method.
-   *
-   * @return The result of last call to Get() or an invalid Future, if there is
-   * no such call.
-   */
-  virtual Future<DocumentSnapshot> GetLastResult() const;
-
   /**
    * @brief Writes to the document referred to by this DocumentReference.
    *
@@ -222,14 +214,6 @@ class DocumentReference {
   virtual Future<void> Set(const MapFieldValue& data,
                            const SetOptions& options = SetOptions());
 
-  /**
-   * @brief Gets the result of the most recent call to the Set() method.
-   *
-   * @return The result of last call to Set() or an invalid Future, if there is
-   * no such call.
-   */
-  virtual Future<void> SetLastResult() const;
-
   /**
    * @brief Updates fields in the document referred to by this
    * DocumentReference.
@@ -255,29 +239,13 @@ class DocumentReference {
    */
   virtual Future<void> Update(const MapFieldPathValue& data);
 
-  /**
-   * @brief Gets the result of the most recent call to Update().
-   *
-   * @return The result of last call to Update() or an invalid Future, if there
-   * is no such call.
-   */
-  virtual Future<void> UpdateLastResult() const;
-
   /**
    * @brief Removes the document referred to by this DocumentReference.
    *
    * @return A Future that will be resolved when the delete completes.
    */
   virtual Future<void> Delete();
 
-  /**
-   * @brief Gets the result of the most recent call to Delete().
-   *
-   * @return The result of last call to Delete() or an invalid Future, if there
-   * is no such call.
-   */
-  virtual Future<void> DeleteLastResult() const;
-
 #if defined(FIREBASE_USE_STD_FUNCTION) || defined(DOXYGEN)
   /**
    * @brief Starts listening to the document referenced by this

firestore/src/include/firebase/firestore/query.h

@@ -524,14 +524,6 @@ class Query {
    */
   virtual Future<QuerySnapshot> Get(Source source = Source::kDefault) const;
 
-  /**
-   * @brief Gets the result of the most recent call to the Get() method.
-   *
-   * @return The result of last call to Get() or an invalid Future, if there is
-   * no such call.
-   */
-  virtual Future<QuerySnapshot> GetLastResult() const;
-
 #if defined(FIREBASE_USE_STD_FUNCTION) || defined(DOXYGEN)
   /**
    * @brief Starts listening to the QuerySnapshot events referenced by this

firestore/src/include/firebase/firestore/write_batch.h

@@ -155,14 +155,6 @@ class WriteBatch {
    */
   virtual Future<void> Commit();
 
-  /**
-   * Gets the result of the most recent call to Commit() methods.
-   *
-   * @return The result of last call to Commit() or an invalid Future, if there
-   * is no such call.
-   */
-  virtual Future<void> CommitLastResult() const;
-
  private:
   friend class FirestoreInternal;
   friend class WriteBatchInternal;