Temporarily avoid usage of util::ThrowInvalidArgument in google3.

The implementation of `util::ThrowInvalidArgument` calls `util::StringFormat`,
which can cause linkage errors on iOS because it has `absl::string_view` in its
signature (which resolves to different types between the Abseil version in
google3 and what's available publicly). As a temporary workaround, call
`util::Throw` directly.

PiperOrigin-RevId: 296075191

Author: var-const

firestore/src/ios/hard_assert_ios.cc

@@ -0,0 +1,14 @@
+#include "firestore/src/ios/hard_assert_ios.h"
+
+namespace firebase {
+namespace firestore {
+namespace util {
+
+ABSL_ATTRIBUTE_NORETURN void ThrowInvalidArgumentIos(
+    const std::string& message) {
+  Throw(ExceptionType::InvalidArgument, nullptr, nullptr, 0, message);
+}
+
+}  // namespace util
+}  // namespace firestore
+}  // namespace firebase

firestore/src/ios/hard_assert_ios.h

@@ -24,8 +24,8 @@
 #include "Firestore/core/src/firebase/firestore/util/exception.h"
 
 // TODO(b/147444199): delete this file and use the one that comes from the
-// GitHub repo. This file provides simplified versions of `HARD_ASSERT` and
-// `HARD_FAIL` that don't support string formatting.
+// GitHub repo. This file provides simplified versions of `HARD_ASSERT`,
+// `HARD_FAIL`, and `ThrowInvalidArgument` that don't support string formatting.
 
 #if defined(_MSC_VER)
 #define FIRESTORE_FUNCTION_NAME __FUNCSIG__
@@ -116,6 +116,13 @@ ABSL_ATTRIBUTE_NORETURN void FailAssertion(const char* file, const char* func,
                                            const char* condition);
 
 }  // namespace internal
+
+// This is a workaround for the fact that `util::ThrowInvalidArgument` calls
+// `StringFormat` in its implementation, which leads to linkage problems due to
+// the use of `absl::string_view` in its signature.
+ABSL_ATTRIBUTE_NORETURN void ThrowInvalidArgumentIos(
+    const std::string& message);
+
 }  // namespace util
 }  // namespace firestore
 }  // namespace firebase

firestore/src/ios/query_ios.cc

@@ -25,7 +25,7 @@ namespace firestore {
 
 using model::DocumentKey;
 using model::ResourcePath;
-using util::ThrowInvalidArgument;
+using util::ThrowInvalidArgumentIos;
 
 QueryInternal::QueryInternal(api::Query&& query)
     : query_{std::move(query)},
@@ -124,7 +124,7 @@ bool operator==(const QueryInternal& lhs, const QueryInternal& rhs) {
 core::Bound QueryInternal::ToBound(
     BoundPosition bound_pos, const DocumentSnapshot& public_snapshot) const {
   if (!public_snapshot.exists()) {
-    ThrowInvalidArgument(
+    ThrowInvalidArgumentIos(
         "Invalid query. You are trying to start or end a query using a "
         "document that doesn't exist.");
   }
@@ -163,7 +163,7 @@ core::Bound QueryInternal::ToBound(
                          "query using a document for which the field '") +
                      field_path.CanonicalString() +
                      "' (used as the order by) does not exist.";
-      ThrowInvalidArgument(message.c_str());
+      ThrowInvalidArgumentIos(message.c_str());
     }
 
     if (value->type() == model::FieldValue::Type::ServerTimestamp) {
@@ -181,7 +181,7 @@ core::Bound QueryInternal::ToBound(
           field_path.CanonicalString() +
           "' is an uncommitted server timestamp. (Since the value of this"
           "field is unknown, you cannot start/end a query with it.)";
-      ThrowInvalidArgument(message.c_str());
+      ThrowInvalidArgumentIos(message.c_str());
     }
 
     components.push_back(std::move(value).value());
@@ -199,7 +199,7 @@ core::Bound QueryInternal::ToBound(
       internal_query.explicit_order_bys();
 
   if (field_values.size() > explicit_order_bys.size()) {
-    ThrowInvalidArgument(
+    ThrowInvalidArgumentIos(
         "Invalid query. You are trying to start or end a query using more "
         "values than were specified in the order by.");
   }
@@ -223,7 +223,7 @@ core::Bound QueryInternal::ToBound(
 model::FieldValue QueryInternal::ConvertDocumentId(
     const model::FieldValue& from, const core::Query& internal_query) const {
   if (from.type() != model::FieldValue::Type::String) {
-    ThrowInvalidArgument(
+    ThrowInvalidArgumentIos(
         "Invalid query. Expected a string for the document ID.");
   }
   const std::string& document_id = from.string_value();
@@ -240,7 +240,7 @@ model::FieldValue QueryInternal::ConvertDocumentId(
                        "by document "
                        "ID, you must pass a plain document ID, but '") +
                    document_id + "' contains a slash.";
-    ThrowInvalidArgument(message.c_str());
+    ThrowInvalidArgumentIos(message.c_str());
   }
 
   ResourcePath path =
@@ -259,7 +259,7 @@ model::FieldValue QueryInternal::ConvertDocumentId(
             "document path, but '") +
         path.CanonicalString() +
         "' is not because it contains an odd number of segments.";
-    ThrowInvalidArgument(message.c_str());
+    ThrowInvalidArgumentIos(message.c_str());
   }
 
   const model::DatabaseId& database_id = firestore_internal()->database_id();

firestore/src/ios/user_data_converter_ios.cc

@@ -31,7 +31,7 @@ using model::NumericIncrementTransform;
 using model::ServerTimestampTransform;
 using model::TransformOperation;
 using nanopb::ByteString;
-using util::ThrowInvalidArgument;
+using util::ThrowInvalidArgumentIos;
 
 using Type = FieldValue::Type;
 
@@ -58,7 +58,7 @@ void ParseDelete(ParseContext&& context) {
             "FieldValue::Delete() can only appear at the top level of your "
             "update data") +
         context.FieldDescription();
-    ThrowInvalidArgument(message.c_str());
+    ThrowInvalidArgumentIos(message.c_str());
   }
 
   // We shouldn't encounter delete sentinels for queries or non-merge `Set`
@@ -73,7 +73,7 @@ void ParseDelete(ParseContext&& context) {
           "FieldValue::Delete() can only be used with Update() and Set() with "
           "merge == true") +
       context.FieldDescription();
-  ThrowInvalidArgument(message.c_str());
+  ThrowInvalidArgumentIos(message.c_str());
 }
 
 void ParseServerTimestamp(ParseContext&& context) {
@@ -141,7 +141,7 @@ FieldMask CreateFieldMask(const ParseAccumulator& accumulator,
       auto message =
           std::string("Field '") + path.CanonicalString() +
           "' is specified in your field mask but missing from your input data.";
-      ThrowInvalidArgument(message.c_str());
+      ThrowInvalidArgumentIos(message.c_str());
     }
 
     validated.insert(path);
@@ -273,7 +273,7 @@ model::FieldValue::Array UserDataConverter::ParseArray(
   // disable this validation.
   if (context.array_element() &&
       context.data_source() != core::UserDataSource::ArrayArgument) {
-    ThrowInvalidArgument("Nested arrays are not supported");
+    ThrowInvalidArgumentIos("Nested arrays are not supported");
   }
 
   model::FieldValue::Array result;
@@ -325,7 +325,7 @@ void UserDataConverter::ParseSentinel(const FieldValue& value,
     auto message = Describe(value.type()) +
                    " can only be used with Update() and Set()" +
                    context.FieldDescription();
-    ThrowInvalidArgument(message.c_str());
+    ThrowInvalidArgumentIos(message.c_str());
   }
 
   if (!context.path()) {
@@ -334,7 +334,7 @@ void UserDataConverter::ParseSentinel(const FieldValue& value,
     //                      Describe(value.type()));
     auto message =
         Describe(value.type()) + " is not currently supported inside arrays";
-    ThrowInvalidArgument(message.c_str());
+    ThrowInvalidArgumentIos(message.c_str());
   }
 
   switch (value.type()) {
@@ -415,7 +415,7 @@ model::FieldValue UserDataConverter::ParseScalar(const FieldValue& value,
         auto message = std::string("DocumentReference is for database ") +
                        actual_db + " but should be for database " +
                        expected_db + context.FieldDescription();
-        ThrowInvalidArgument(message.c_str());
+        ThrowInvalidArgumentIos(message.c_str());
       }
 
       const model::DocumentKey& key = GetInternal(&reference)->key();