Fix up before review

Author: AustinBenoit

.github/workflows/integration_tests.yml

@@ -360,7 +360,7 @@ jobs:
         if: startsWith(matrix.os, 'windows')
         shell: bash
         run: |
-          find "testapps-desktop-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.ssl_variant }}" -name integration_test.exe -exec dirname {} \; | while read dir; do cp analytics/windows/analytics_win.dll "$dir/"; done
+          find "testapps-desktop-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.ssl_variant }}" -name integration_test.exe -exec dirname {} \; | while read dir; do cp analytics/windows/google_analytics.dll "$dir/"; done
       - name: Upload Desktop Cmake
         uses: actions/upload-artifact@v4
         if: ${{ !cancelled() }}

analytics/integration_test/src/integration_test.cc

@@ -256,7 +256,6 @@ TEST_F(FirebaseAnalyticsTest, TestSetLogCallback) {
         finishedPromise.set_value();
       });
 
-  // Pass kUnknown to trigger a warning log directly from the DLL (on Windows),
   firebase::analytics::NotifyAppLifecycleChange(firebase::analytics::kUnknown);
 
   if (finished.wait_for(std::chrono::seconds(60)) ==

analytics/src/analytics_desktop.cc

@@ -412,7 +412,7 @@ LogLevel ConvertAnalyticsLogLevelToFirebaseLogLevel(
 }
 
 
-extern "C" void GoogleAnalyticsWrapperLogCallback(
+void GoogleAnalyticsWrapperLogCallback(
     GoogleAnalytics_LogLevel log_level, const char* message) {
   LogCallback callback_to_call;
 

analytics/src/include/firebase/analytics.h

@@ -612,6 +612,7 @@ void ResetAnalyticsData();
 /// @brief The callback type for logging messages from the SDK.
 ///
 /// The callback is invoked whenever the SDK logs a message.
+/// Currently only works for Windows Desktop.
 ///
 /// @param[in] log_level The log level of the message.
 /// @param[in] message The message logged by the SDK.
@@ -639,10 +640,9 @@ enum AppLifecycleState { kUnknown = 0, kTermination };
 /// kTermination is used to indicate that the app is about to be terminated.
 /// The caller will be blocked until all pending data is uploaded or an error
 /// occurs. The caller must ensure the OS does not terminate background threads
-/// before the call returns.
+/// before the call returns. Currently only works for Windows Desktop.
 ///
 /// @param[in] state The current state of the app's lifecycle.
-
 void NotifyAppLifecycleChange(AppLifecycleState state);
 
 /// Get the instance ID from the analytics service.