Check for null resourceName before attempting to delete a cert (#669)

Without this, the sdk will send a null resourceName to the server,
resulting in a somewhat misleading 404 error being returned.

Author: rsgowman

src/project-management/android-app.ts

@@ -103,6 +103,12 @@ export class AndroidApp {
   }
 
   public deleteShaCertificate(certificateToDelete: ShaCertificate): Promise<void> {
+    if (!certificateToDelete.resourceName) {
+      throw new FirebaseProjectManagementError(
+          'invalid-argument',
+          'Specified certificate does not include a resourceName. (Use AndroidApp.getShaCertificates() to retrieve ' +
+              'certificates with a resourceName.');
+    }
     return this.requestHandler.deleteResource(certificateToDelete.resourceName);
   }
 

src/utils/error.ts

@@ -312,6 +312,12 @@ export class FirebaseMessagingError extends PrefixedFirebaseError {
 export class FirebaseProjectManagementError extends PrefixedFirebaseError {
   constructor(code: ProjectManagementErrorCode, message: string) {
     super('project-management', code, message);
+
+    /* tslint:disable:max-line-length */
+    // Set the prototype explicitly. See the following link for more details:
+    // https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes#extending-built-ins-like-error-array-and-map-may-no-longer-work
+    /* tslint:enable:max-line-length */
+    (this as any).__proto__ = FirebaseProjectManagementError.prototype;
   }
 }
 

test/integration/project-management.spec.ts

@@ -175,6 +175,18 @@ describe('admin.projectManagement', () => {
             expect(certs.length).to.equal(0);
           });
     });
+
+    it('add a cert and then remove it fails due to missing resourceName',
+       () => {
+         const shaCertificate =
+             admin.projectManagement().shaCertificate(SHA_256_HASH);
+         return androidApp.addShaCertificate(shaCertificate)
+             .then(() => androidApp.deleteShaCertificate(shaCertificate))
+             .should.eventually.be
+             .rejectedWith(
+                 'Specified certificate does not include a resourceName')
+             .with.property('code', 'project-management/invalid-argument');
+       });
   });
 
   describe('androidApp.getConfig()', () => {

test/unit/project-management/android-app.spec.ts

@@ -289,22 +289,33 @@ describe('AndroidApp', () => {
 
   describe('deleteShaCertificate', () => {
     const certificateToDelete = new ShaCertificate(VALID_SHA_1_HASH);
+    const certificateToDeleteWithResourceName =
+        new ShaCertificate(VALID_SHA_1_HASH, 'resource/name');
 
     it('should propagate API errors', () => {
       const stub = sinon
           .stub(ProjectManagementRequestHandler.prototype, 'deleteResource')
           .returns(Promise.reject(EXPECTED_ERROR));
       stubs.push(stub);
-      return androidApp.deleteShaCertificate(certificateToDelete)
+      return androidApp
+          .deleteShaCertificate(certificateToDeleteWithResourceName)
           .should.eventually.be.rejected.and.equal(EXPECTED_ERROR);
     });
 
+    it('should fail on certificate without resourceName', () => {
+      expect(() => androidApp.deleteShaCertificate(certificateToDelete))
+          .to.throw(FirebaseProjectManagementError)
+          .with.property('code', 'project-management/invalid-argument');
+    });
+
     it('should resolve on success', () => {
       const stub = sinon
           .stub(ProjectManagementRequestHandler.prototype, 'deleteResource')
           .returns(Promise.resolve());
       stubs.push(stub);
-      return androidApp.deleteShaCertificate(certificateToDelete).should.eventually.be.fulfilled;
+      return androidApp
+          .deleteShaCertificate(certificateToDeleteWithResourceName)
+          .should.eventually.be.fulfilled;
     });
   });