Exit with a non-zero status code if upload does not finish

Author: lfkellogg

lib/fastlane/plugin/firebase_app_distribution/client/firebase_app_distribution_api_client.rb

@@ -159,8 +159,7 @@ def upload(project_number, app_id, binary_path, platform)
             end
           end
           unless upload_status_response.success?
-            UI.error("It took longer than expected to process your #{binary_type}, please try again.")
-            return nil
+            UI.crash!("It took longer than expected to process your #{binary_type}, please try again.")
           end
         end
         upload_status_response.release_id

spec/firebase_app_distribution_api_client_spec.rb

@@ -203,7 +203,7 @@
       expect(release_id).to eq("release_id")
     end
 
-    it 'returns nil after polling MAX_POLLING_RETRIES times' do
+    it 'raises an error after polling MAX_POLLING_RETRIES times' do
       max_polling_retries = 2
       stub_const("Fastlane::Client::FirebaseAppDistributionApiClient::MAX_POLLING_RETRIES", max_polling_retries)
 
@@ -217,8 +217,9 @@
         .and_return(upload_status_response_in_progress)
         .exactly(max_polling_retries).times
 
-      release_id = api_client.upload("project_number", "app_id", fake_binary_path, "android")
-      expect(release_id).to be_nil
+      expect do
+        api_client.upload("project_number", "app_id", fake_binary_path, "android")
+      end.to raise_error
     end
 
     it 'uploads the app binary once then polls until success' do