Merge pull request #364 from firebase/lk/api-review-updates

Changes from API review

Author: lfkellogg

lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb

@@ -88,8 +88,9 @@ def self.run(params)
           get_value_from_value_or_file(params[:test_devices], params[:test_devices_file])
         if present?(test_devices)
           UI.message("🤖 Starting automated tests. Note: This feature is in beta.")
-          release_test = test_release(alpha_client, release, test_devices, params[:test_username], params[:test_password], params[:test_username_resource], params[:test_password_resource])
-          unless params[:test_async]
+          test_password = test_password_from_params(params)
+          release_test = test_release(alpha_client, release, test_devices, params[:test_username], test_password, params[:test_username_resource], params[:test_password_resource])
+          unless params[:test_non_blocking]
             poll_test_finished(alpha_client, release_test.name)
           end
         end
@@ -133,6 +134,12 @@ def self.details
         "Release your beta builds with Firebase App Distribution"
       end
 
+      def self.test_password_from_params(params)
+        test_password = get_value_from_value_or_file(params[:test_password], params[:test_password_file])
+        # Remove trailing newline if present
+        test_password && test_password.sub(/\r?\n$/, "")
+      end
+
       def self.app_id_from_params(params)
         if params[:app]
           app_id = params[:app]
@@ -522,23 +529,33 @@ def self.available_options
                                        optional: true,
                                        type: String),
           FastlaneCore::ConfigItem.new(key: :test_username,
+                                       env_name: "FIREBASEAPPDISTRO_TEST_USERNAME",
                                        description: "Username for automatic login",
                                        optional: true,
                                        type: String),
           FastlaneCore::ConfigItem.new(key: :test_password,
-                                       description: "Password for automatic login",
+                                       env_name: "FIREBASEAPPDISTRO_TEST_PASSWORD",
+                                       description: "Password for automatic login. If using a real password consider using test_password_file or setting FIREBASEAPPDISTRO_TEST_PASSWORD to avoid exposing sensitive info",
                                        optional: true,
                                        type: String),
+          FastlaneCore::ConfigItem.new(key: :test_password_file,
+                                       env_name: "FIREBASEAPPDISTRO_TEST_PASSWORD_FILE",
+                                      description: "Path to file containing password for automatic login",
+                                      optional: true,
+                                      type: String),
           FastlaneCore::ConfigItem.new(key: :test_username_resource,
+                                       env_name: "FIREBASEAPPDISTRO_TEST_USERNAME_RESOURCE",
                                        description: "Resource name for the username field for automatic login",
                                        optional: true,
                                        type: String),
           FastlaneCore::ConfigItem.new(key: :test_password_resource,
+                                       env_name: "FIREBASEAPPDISTRO_TEST_PASSWORD_RESOURCE",
                                        description: "Resource name for the password field for automatic login",
                                        optional: true,
                                        type: String),
-          FastlaneCore::ConfigItem.new(key: :test_async,
-                                       description: "Run tests asynchronously. Visit the Firebase console for the automatic test results",
+          FastlaneCore::ConfigItem.new(key: :test_non_blocking,
+                                       env_name: "FIREBASEAPPDISTRO_TEST_NON_BLOCKING",
+                                       description: "Run automated tests without waiting for them to finish. Visit the Firebase console for the test results",
                                        optional: false,
                                        default_value: false,
                                        type: Boolean),

lib/fastlane/plugin/firebase_app_distribution/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module FirebaseAppDistribution
-    VERSION = "0.9.0.pre.4"
+    VERSION = "0.9.0.pre.5"
   end
 end

spec/firebase_app_distribution_action_spec.rb

@@ -561,7 +561,7 @@ def stub_get_aab_info(integration_state = 'INTEGRATED')
                            test_username: 'username',
                            test_password: 'password',
                            test_devices: 'model=model1,version=version1,locale=locale1,orientation=orientation1',
-                           test_async: true
+                           test_non_blocking: true
                          })
             end
 
@@ -580,7 +580,7 @@ def stub_get_aab_info(integration_state = 'INTEGRATED')
                            test_username: 'username',
                            test_password: 'password',
                            test_devices: 'model=model1,version=version1,locale=locale1,orientation=orientation1',
-                           test_async: true
+                           test_non_blocking: true
                          })
             end
 
@@ -610,7 +610,7 @@ def stub_get_aab_info(integration_state = 'INTEGRATED')
                                               app: android_app_id,
                                               android_artifact_path: 'path/to.apk',
                                               test_devices: devices,
-                                              test_async: true
+                                              test_non_blocking: true
                                             })
             end
           end