Merge pull request #196 from fastlane/lk/fix-release-notes-file-default

Make --release_notes_file take precedence over FL_CHANGELOG

Author: lfkellogg

.ruby-version

@@ -0,0 +1 @@
+2.6.3

lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb

@@ -53,8 +53,7 @@ def self.run(params)
           end
         end
 
-        release_notes = get_value_from_value_or_file(params[:release_notes], params[:release_notes_file])
-        fad_api_client.post_notes(app_id, release_id, release_notes)
+        fad_api_client.post_notes(app_id, release_id, release_notes(params))
 
         testers = get_value_from_value_or_file(params[:testers], params[:testers_file])
         groups = get_value_from_value_or_file(params[:groups], params[:groups_file])
@@ -153,6 +152,12 @@ def self.validate_app!(app, binary_type)
         end
       end
 
+      def self.release_notes(params)
+        release_notes_param =
+          get_value_from_value_or_file(params[:release_notes], params[:release_notes_file])
+        release_notes_param || Actions.lane_context[SharedValues::FL_CHANGELOG]
+      end
+
       def self.available_options
         [
           # iOS Specific
@@ -217,8 +222,6 @@ def self.available_options
           FastlaneCore::ConfigItem.new(key: :release_notes,
                                        env_name: "FIREBASEAPPDISTRO_RELEASE_NOTES",
                                        description: "Release notes for this build",
-                                       default_value: Actions.lane_context[SharedValues::FL_CHANGELOG],
-                                       default_value_dynamic: true,
                                        optional: true,
                                        type: String),
           FastlaneCore::ConfigItem.new(key: :release_notes_file,

spec/firebase_app_distribution_action_spec.rb

@@ -170,6 +170,45 @@
     end
   end
 
+  describe '#release_notes' do
+    before do
+      allow(Fastlane::Actions.lane_context).to receive('[]')
+        .with(Fastlane::Actions::SharedValues::FL_CHANGELOG)
+        .and_return('changelog-content')
+    end
+
+    describe 'when no release notes are set' do
+      let(:params) { {} }
+      it 'defaults to changelog' do
+        expect(action.release_notes(params)).to eq('changelog-content')
+      end
+    end
+
+    describe 'when only release_notes_file is set' do
+      let(:params) { { release_notes_file: 'release-notes-file-path' } }
+      let(:fake_file) { double('File') }
+
+      it 'uses release_notes_file' do
+        expect(fake_file).to receive(:read).and_return('release-notes-file-content')
+        expect(File).to receive(:open).with('release-notes-file-path').and_return(fake_file)
+        expect(action.release_notes(params)).to eq('release-notes-file-content')
+      end
+    end
+
+    describe 'when release_notes and release_notes_file are set' do
+      let(:params) do
+        {
+          release_notes: 'release-notes-content',
+          release_notes_file: 'release-notes-file-path'
+        }
+      end
+
+      it 'uses release_notes' do
+        expect(action.release_notes(params)).to eq('release-notes-content')
+      end
+    end
+  end
+
   describe '#run' do
     let(:params) do
       {

spec/firebase_app_distribution_helper_spec.rb

@@ -48,6 +48,10 @@
       expect { helper.get_value_from_value_or_file(nil, "invalid_path") }
         .to raise_error("#{ErrorMessage::INVALID_PATH}: invalid_path")
     end
+
+    it 'returns nil when the value and path are both nil' do
+      expect(helper.get_value_from_value_or_file(nil, nil)).to eq(nil)
+    end
   end
 
   describe '#string_to_array' do