test(fuzz): checkUserPushPermissions

Author: jescalada

test/processors/checkCommitMessages.test.js

@@ -180,9 +180,9 @@ describe('checkCommitMessages', () => {
                 'fuzz/repo'
               );
               fuzzAction.commitData = Array.isArray(fuzzedCommits) ? fuzzedCommits : [];
-      
+
               const result = await exec({}, fuzzAction);
-      
+
               expect(result).to.have.property('steps');
               expect(result.steps[0]).to.have.property('error').that.is.a('boolean');
             }

test/processors/checkUserPushPermission.test.js

@@ -1,12 +1,13 @@
 const chai = require('chai');
 const sinon = require('sinon');
 const proxyquire = require('proxyquire');
+const fc = require('fast-check');
 const { Action, Step } = require('../../src/proxy/actions');
 
 chai.should();
 const expect = chai.expect;
 
-describe('checkUserPushPermission', () => {
+describe.only('checkUserPushPermission', () => {
   let exec;
   let getUsersStub;
   let isUserPushAllowedStub;
@@ -98,5 +99,26 @@ describe('checkUserPushPermission', () => {
       expect(result.steps[0].error).to.be.true;
       expect(logStub.calledWith('Users for this git account: [{"username":"user1","gitAccount":"git-user"},{"username":"user2","gitAccount":"git-user"}]')).to.be.true;
     });
+
+    describe('fuzzing', () => {
+      it('should not crash on arbitrary getUsers return values (fuzzing)', async () => {
+        const userList = fc.sample(
+          fc.array(
+            fc.record({
+              username: fc.string(),
+              gitAccount: fc.string()
+            }),
+            { maxLength: 5 }
+          ),
+          1
+        )[0];
+        getUsersStub.resolves(userList);
+
+        const result = await exec(req, action);
+
+        expect(result.steps).to.have.lengthOf(1);
+        expect(result.steps[0].error).to.be.true;
+      });
+    });
   });
 });