test: adjust test to match schema and tighten schema slightly

Author: kriswest

config.schema.json

@@ -27,10 +27,12 @@
                 "https://somedomain.com/some/path/checkUserGroups?domain=<domain>&name=<name>&id=<id>"
               ]
             }
-          }
+          },
+          "additionalProperties": false
         },
         "github": {
           "type": "object",
+          "description": "Deprecated: Defunct property that was used to provide the API URL for GitHub. No longer referenced in the codebase.",
           "properties": {
             "baseUrl": {
               "type": "string",
@@ -41,7 +43,8 @@
           },
           "additionalProperties": false
         }
-      }
+      },
+      "additionalProperties": false
     },
     "commitConfig": {
       "description": "Enforce rules and patterns on commits including e-mail and message",

src/config/generated/config.ts

@@ -108,16 +108,23 @@ export interface GitProxyConfig {
  * Third party APIs
  */
 export interface API {
+  /**
+   * Deprecated: Defunct property that was used to provide the API URL for GitHub. No longer
+   * referenced in the codebase.
+   */
   github?: Github;
   /**
    * Configuration used in conjunction with ActiveDirectory auth, which relates to a REST API
    * used to check user group membership, as opposed to direct querying via LDAP.<br />If this
    * configuration is set direct querying of group membership via LDAP will be disabled.
    */
   ls?: Ls;
-  [property: string]: any;
 }
 
+/**
+ * Deprecated: Defunct property that was used to provide the API URL for GitHub. No longer
+ * referenced in the codebase.
+ */
 export interface Github {
   baseUrl?: string;
 }
@@ -138,7 +145,6 @@ export interface Ls {
    * membership of.</li><li>"&lt;id&gt;": The username to check group membership for.</li></ul>
    */
   userInADGroup?: string;
-  [property: string]: any;
 }
 
 /**
@@ -531,10 +537,10 @@ const typeMap: any = {
       { json: 'github', js: 'github', typ: u(undefined, r('Github')) },
       { json: 'ls', js: 'ls', typ: u(undefined, r('Ls')) },
     ],
-    'any',
+    false,
   ),
   Github: o([{ json: 'baseUrl', js: 'baseUrl', typ: u(undefined, '') }], false),
-  Ls: o([{ json: 'userInADGroup', js: 'userInADGroup', typ: u(undefined, '') }], 'any'),
+  Ls: o([{ json: 'userInADGroup', js: 'userInADGroup', typ: u(undefined, '') }], false),
   Authentication: o(
     [
       { json: 'enabled', js: 'enabled', typ: true },

test/generated-config.test.js

@@ -1,6 +1,7 @@
 const chai = require('chai');
 const { Convert } = require('../src/config/generated/config');
 const defaultSettings = require('../proxy.config.json');
+const { isUserInAdGroup } = require('../src/service/passport/ldaphelper');
 
 const { expect } = chai;
 
@@ -207,11 +208,12 @@ describe('Generated Config (QuickType)', () => {
         sink: [{ type: 'fs', params: { filepath: './.' }, enabled: true }],
 
         api: {
+          ls: {
+            userInADGroup:
+              'https://somedomain.com/some/path/checkUserGroups?domain=<domain>&name=<name>&id=<id>',
+          },
           github: {
             baseUrl: 'https://api.github.com',
-            token: 'secret-token',
-            rateLimit: 100,
-            enabled: true,
           },
         },