Merge pull request #1124 from jescalada/default-config-validation-error-fix

fix: default config validation error and extras

Author: coopernetes

index.ts

@@ -1,5 +1,6 @@
 #!/usr/bin/env tsx
 /* eslint-disable max-len */
+import path from 'path';
 import yargs from 'yargs';
 import { hideBin } from 'yargs/helpers';
 import * as fs from 'fs';
@@ -19,7 +20,7 @@ const argv = yargs(hideBin(process.argv))
     },
     config: {
       description: 'Path to custom git-proxy configuration file.',
-      default: 'proxy.config.json',
+      default: path.join(__dirname, 'proxy.config.json'),
       required: false,
       alias: 'c',
       type: 'string',

package-lock.json

@@ -2,7 +2,7 @@ import { readFileSync } from 'fs';
 import { join } from 'path';
 import { validate as jsonSchemaValidate } from 'jsonschema';
 
-export let configFile: string = join(process.cwd(), 'proxy.config.json');
+export let configFile: string = join(__dirname, '../../proxy.config.json');
 
 /**
  * Set the config file path.
@@ -20,7 +20,7 @@ export function setConfigFile(file: string) {
  */
 export function validate(configFilePath: string = configFile!): boolean {
   const config = JSON.parse(readFileSync(configFilePath, 'utf-8'));
-  const schemaPath = join(process.cwd(), 'config.schema.json');
+  const schemaPath = join(__dirname, '../../config.schema.json');
   const schema = JSON.parse(readFileSync(schemaPath, 'utf-8'));
   jsonSchemaValidate(config, schema, { required: true, throwError: true });
   return true;

src/config/file.ts

@@ -126,13 +126,7 @@ export const getAPIAuthMethods = (): Authentication[] => {
     _apiAuthentication = _userSettings.apiAuthentication;
   }
 
-  const enabledAuthMethods = _apiAuthentication.filter((auth) => auth.enabled);
-
-  if (enabledAuthMethods.length === 0) {
-    console.log('Warning: No authentication method enabled for API endpoints.');
-  }
-
-  return enabledAuthMethods;
+  return _apiAuthentication.filter((auth) => auth.enabled);
 };
 
 // Log configuration to console