chore: address requested changes

Author: fabiovincenzi

src/proxy/processors/push-action/checkHiddenCommits.ts

@@ -47,11 +47,14 @@ const exec = async (req: any, action: Action): Promise<Action> => {
     const isSubset = [...packCommits].every((sha) => introducedCommits.has(sha));
     if (!isSubset) {
       // build detailed lists
-      const unreferenced = [...packCommits].filter((sha) => !introducedCommits.has(sha));
-      const referenced = [...packCommits].filter((sha) => introducedCommits.has(sha));
+      const [referenced, unreferenced] = [...packCommits].reduce<[string[], string[]]>(
+        ([ref, unref], sha) =>
+          introducedCommits.has(sha) ? [[...ref, sha], unref] : [ref, [...unref, sha]],
+        [[], []],
+      );
 
-      step.log(`✅ Referenced commits: ${referenced.length}`);
-      step.log(`❌ Unreferenced commits: ${unreferenced.length}`);
+      step.log(`Referenced commits: ${referenced.length}`);
+      step.log(`Unreferenced commits: ${unreferenced.length}`);
 
       step.setError(
         `Unreferenced commits in pack (${unreferenced.length}): ${unreferenced.join(', ')}`,

src/proxy/processors/push-action/writePack.ts

@@ -22,9 +22,9 @@ const exec = async (req: any, action: Action) => {
       cwd: action.proxyGitPath,
       input: req.body,
     });
-    const after = new Set(fs.readdirSync(packDir).filter((f) => f.endsWith('.idx')));
-
-    const newIdxFiles = [...after].filter((f) => !before.has(f));
+    const newIdxFiles = [
+      ...new Set(fs.readdirSync(packDir).filter((f) => f.endsWith('.idx') && !before.has(f))),
+    ];
     action.newIdxFiles = newIdxFiles;
     step.log(`new idx files: ${newIdxFiles}`);
 

test/checkHiddenCommit.test.js

@@ -32,7 +32,7 @@ describe('checkHiddenCommits.exec', () => {
     sandbox.restore();
   });
 
-  it.only('reports all commits unreferenced and sets error=true', async () => {
+  it('reports all commits unreferenced and sets error=true', async () => {
     const COMMIT_1 = 'deadbeef';
     const COMMIT_2 = 'cafebabe';
 
@@ -51,15 +51,15 @@ describe('checkHiddenCommits.exec', () => {
     await checkHidden({ body: '' }, action);
 
     const step = action.steps.find((s) => s.stepName === 'checkHiddenCommits');
-    expect(step.logs).to.include(`checkHiddenCommits - ✅ Referenced commits: 0`);
-    expect(step.logs).to.include(`checkHiddenCommits - ❌ Unreferenced commits: 2`);
+    expect(step.logs).to.include(`checkHiddenCommits - Referenced commits: 0`);
+    expect(step.logs).to.include(`checkHiddenCommits - Unreferenced commits: 2`);
     expect(step.logs).to.include(
       `checkHiddenCommits - Unreferenced commits in pack (2): ${COMMIT_1}, ${COMMIT_2}`,
     );
     expect(action.error).to.be.true;
   });
 
-  it.only('mixes referenced & unreferenced correctly', async () => {
+  it('mixes referenced & unreferenced correctly', async () => {
     const COMMIT_1 = 'deadbeef';
     const COMMIT_2 = 'cafebabe';
 
@@ -78,15 +78,15 @@ describe('checkHiddenCommits.exec', () => {
     await checkHidden({ body: '' }, action);
 
     const step = action.steps.find((s) => s.stepName === 'checkHiddenCommits');
-    expect(step.logs).to.include('checkHiddenCommits - ✅ Referenced commits: 1');
-    expect(step.logs).to.include('checkHiddenCommits - ❌ Unreferenced commits: 1');
+    expect(step.logs).to.include('checkHiddenCommits - Referenced commits: 1');
+    expect(step.logs).to.include('checkHiddenCommits - Unreferenced commits: 1');
     expect(step.logs).to.include(
       `checkHiddenCommits - Unreferenced commits in pack (1): ${COMMIT_2}`,
     );
     expect(action.error).to.be.true;
   });
 
-  it.only('reports all commits referenced and sets error=false', async () => {
+  it('reports all commits referenced and sets error=false', async () => {
     // 1) rev-list → introduces both commits
     // 2) verify-pack → the pack contains the same two commits
     spawnSyncStub.onFirstCall().returns({ stdout: 'deadbeef\ncafebabe\n' }).onSecondCall().returns({
@@ -106,7 +106,7 @@ describe('checkHiddenCommits.exec', () => {
     expect(action.error).to.be.false;
   });
 
-  it.only('throws if commitFrom or commitTo is missing', async () => {
+  it('throws if commitFrom or commitTo is missing', async () => {
     delete action.commitFrom;
 
     try {