`filecoin-pin data-set show` doesn't list `IPFS Root CID` in the metadata

[BigLep]

If I do filecoin-pin data-set show 147, I see

┌  Filecoin Onchain Cloud Data Set Details for #147
│
◇  ━━━ Data Set ━━━
│
│  Network: calibration
│  Client address: 0x6080Df36FD9B74D04dB3ecCC23b17D6b748CDc26
│  
│  #147
│    Status: live
│    CDN add-on: disabled
│  
│    Provider
│      ID: 5
│      Address: 0xB709A785c765d7d3F7d94dbA367DA6a611D7972b
│      Name: Mongo2Stor
│      Description: CA, US
│      Service URL: http://warp.lotus.dedyn.io:9555
│      Active: yes
│      Location: C=US;ST=California;L=Chino
│  
│    Metadata
│      source: "filecoin-pin"
│      withIPFSIndexing: ""
│  
│    Payment
│      PDP rail ID: 210
│      Payer: 0x6080Df36FD9B74D04dB3ecCC23b17D6b748CDc26
│      Payee: 0xB709A785c765d7d3F7d94dbA367DA6a611D7972b
│  
│    Pieces
│      Total pieces: 2
│      Total size: 448.0 B
│      Unique PieceCIDs: 2
│      Unique IPFS Root CIDs: 2
│  
│      #0
│        PieceCID: bafkzcibcdybqlupck5epc26ud7ilcbgsinepzb3fvig57tw4fytkxbcb4qwpciy
│        IPFS Root CID: bafybeieov6trjrfpzmvr7tpslm3h44a2bssesujddexpoy2gom6nyzlf7a
│        Size: 224.0 B
│        Metadata
│          none
│  
│      #1
│        PieceCID: bafkzcibcdybw5y4yfmonz3cvhpra2w4dwkb3bwwjjpf3xrrsv2nvxkkut3n66ia
│        IPFS Root CID: bafybeihubjugdbaddqco5274vey7r37lrao24h5iqpfmj4ttx7xjsxbu3u
│        Size: 224.0 B
│        Metadata
│          none
│  
│
└  Data set inspection complete

"IPFS Root CID" is listed under each piece, but I would have expected it to be Metadata.

[nijoe1]

Does this retrieves all the pieces and constructs the ipfs-cid at the same time from the car file?

[SgtPooki]

@nijoe1 We are getting the ipfsRootCid from the metadata:

filecoin-pin/src/data-set/display.ts

Line 174 in 443e285

const rootDisplay = piece.rootIpfsCid ?? piece.metadata?.[METADATA_KEYS.IPFS_ROOT_CID] ?? pc.gray('unknown')

@BigLep do we want to display it with nice label and in metadata? or just in metadata?

[BigLep]

do we want to display it with nice label and in metadata? or just in metadata?

Good question. I'm of mixed minds here. I don't think we want to show it twice in CLI output. (It would be different if this is a website where have more presentation controls).

If this was a Synapse CLI then it would certainly just be under the metadata. IPFS Root CID is the key piece of metadata.

I'm good though to just stick it under metadata and not have it hoisted up directly under the piece.