From c453f56038496a310b8bb554401fe9ef4123fcca Mon Sep 17 00:00:00 2001 From: Ninglo <48613687+Ninglo@users.noreply.github.com> Date: Tue, 14 Nov 2023 20:26:51 +0800 Subject: [PATCH 1/2] perf: restore with spans function --- demo-performance.html | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/demo-performance.html b/demo-performance.html index 7d0dd8e..1a57a55 100644 --- a/demo-performance.html +++ b/demo-performance.html @@ -137,9 +137,11 @@ /************************************************************************/ function restoreWithSpans() { - let spans = document.getElementsByClassName(highlightedWithSpanClass); - while(spans.length) { - let span = spans[0]; + while (true) { + const span = document.querySelector(`.highlighted-with-span`); + if (!span) { + break + } span.parentNode.insertBefore(span.firstChild, span); span.parentNode.removeChild(span); } From 392d4dd2c11067d882c1e796d791d92e0610a590 Mon Sep 17 00:00:00 2001 From: Ninglo <48613687+Ninglo@users.noreply.github.com> Date: Wed, 15 Nov 2023 13:07:38 +0800 Subject: [PATCH 2/2] refactore: use const variable --- demo-performance.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/demo-performance.html b/demo-performance.html index 1a57a55..ed669a6 100644 --- a/demo-performance.html +++ b/demo-performance.html @@ -138,7 +138,7 @@ function restoreWithSpans() { while (true) { - const span = document.querySelector(`.highlighted-with-span`); + const span = document.querySelector(`.${highlightedWithSpanClass}`); if (!span) { break } @@ -152,4 +152,4 @@ } - \ No newline at end of file +