chore: update dependencies & @feathersjs/feathers as peerDependency (#721)

* chore: update dependencies & @feathersjs/feathers as peerDependency

* chore: update dependencies & replace devDependency feathers-memory with @feathersjs/memory

Author: fratzinger

package-lock.json

@@ -25,7 +25,7 @@
     "release:major": "npm version major && npm publish",
     "changelog": "github_changelog_generator --max-issues 200 -u feathersjs-ecosystem -p feathers-hooks-common && git add CHANGELOG.md && git commit -am \"Updating changelog\"",
     "lint": "eslint src/**/*.ts test/**/*.ts --fix",
-    "update-dependencies": "ncu -u -x ajv,mongodb",
+    "update-dependencies": "ncu -u -x ajv",
     "mocha": "mocha --require ts-node/register",
     "coverage": "c8 npm run mocha",
     "test": "npm run lint && npm run coverage"
@@ -62,53 +62,54 @@
     "dist/**"
   ],
   "dependencies": {
-    "@feathers-plus/batch-loader": "^0.3.6",
-    "@feathersjs/commons": "^5.0.1",
-    "@feathersjs/errors": "^5.0.1",
-    "@feathersjs/feathers": "^5.0.1",
+    "@feathersjs/errors": "^5.0.6",
     "ajv": "^6.12.6",
     "debug": "^4.3.4",
     "graphql": "^16.6.0",
     "lodash": "^4.17.21",
     "traverse": "^0.6.7"
   },
   "devDependencies": {
+    "@feathers-plus/batch-loader": "^0.3.6",
     "@feathers-plus/cache": "^1.4.0",
     "@feathers-plus/graphql": "^1.10.0",
-    "@feathersjs/authentication": "^5.0.1",
-    "@feathersjs/authentication-local": "^5.0.1",
-    "@feathersjs/client": "^5.0.2",
-    "@feathersjs/express": "^5.0.1",
-    "@feathersjs/socketio": "^5.0.1",
-    "@feathersjs/socketio-client": "^5.0.2",
-    "@types/chai": "^4.3.4",
+    "@feathersjs/authentication": "^5.0.6",
+    "@feathersjs/authentication-local": "^5.0.6",
+    "@feathersjs/client": "^5.0.6",
+    "@feathersjs/express": "^5.0.6",
+    "@feathersjs/memory": "^5.0.6",
+    "@feathersjs/socketio": "^5.0.6",
+    "@feathersjs/socketio-client": "^5.0.6",
+    "@types/chai": "^4.3.5",
     "@types/clone": "^2.1.1",
-    "@types/debug": "^4.1.7",
-    "@types/lodash": "^4.14.192",
+    "@types/debug": "^4.1.8",
+    "@types/lodash": "^4.14.195",
     "@types/mocha": "^10.0.1",
-    "@types/node": "^18.15.11",
+    "@types/node": "^20.3.1",
     "@types/traverse": "^0.6.32",
-    "@typescript-eslint/eslint-plugin": "^5.57.0",
-    "@typescript-eslint/parser": "^5.57.0",
-    "c8": "^7.13.0",
+    "@typescript-eslint/eslint-plugin": "^5.59.11",
+    "@typescript-eslint/parser": "^5.59.11",
+    "c8": "^8.0.0",
     "chai": "^4.3.7",
     "clone": "^2.1.2",
-    "eslint": "^8.37.0",
+    "eslint": "^8.42.0",
     "eslint-config-prettier": "^8.8.0",
     "eslint-plugin-import": "^2.27.5",
     "eslint-plugin-prefer-arrow": "^1.2.3",
     "eslint-plugin-prettier": "^4.2.1",
-    "feathers-memory": "^4.1.0",
     "mocha": "^10.2.0",
-    "mongodb": "^5.0.1",
-    "npm-check-updates": "^16.9.0",
-    "prettier": "^2.8.7",
+    "mongodb": "^5.6.0",
+    "npm-check-updates": "^16.10.12",
+    "prettier": "^2.8.8",
     "shx": "^0.3.4",
     "sift": "^17.0.1",
     "ts-node": "^10.9.1",
     "tsup": "^6.7.0",
-    "typescript": "^5.0.3",
-    "vitepress": "^1.0.0-alpha.64"
+    "typescript": "^5.1.3",
+    "vitepress": "^1.0.0-beta.2"
+  },
+  "peerDependencies": {
+    "@feathersjs/feathers": "^5.0.0"
   },
   "engines": {
     "node": ">= 14"

package.json

@@ -28,13 +28,7 @@ export function setField<H extends HookContext = HookContext>({
   }
 
   return (context: H) => {
-    const { params, app } = context;
-
-    if (app.version < '4.0.0') {
-      throw new Error(
-        "The 'setField' hook only works with Feathers 4 and the latest database adapters"
-      );
-    }
+    const { params } = context;
 
     checkContext(context, 'before', null, 'setField');
 

src/hooks/set-field.ts

@@ -1,4 +1,3 @@
-import { GeneralError } from '@feathersjs/errors';
 import type { HookContext } from '@feathersjs/feathers';
 import { checkContext } from '../utils/check-context';
 
@@ -28,14 +27,10 @@ export function softDelete<H extends HookContext = HookContext>({
   removeData = defaultData,
 }: SoftDeleteOptions<H> = {}) {
   return async (context: H) => {
-    const { service, method, params, app } = context;
+    const { service, method, params } = context;
     // @ts-ignore
     const { disableSoftDelete, query = {} } = params;
 
-    if (app.version < '4.0.0') {
-      throw new GeneralError('The softDelete hook requires Feathers 4.0.0 or later');
-    }
-
     checkContext(context, 'before', null, 'softDelete');
 
     if (disableSoftDelete) {

src/hooks/soft-delete.ts

@@ -1,5 +1,5 @@
 import { feathers } from '@feathersjs/feathers';
-import memory from 'feathers-memory';
+import { MemoryService } from '@feathersjs/memory';
 import getInitDb from './get-init-db';
 
 export default function (dbNames: any) {
@@ -21,18 +21,18 @@ export default function (dbNames: any) {
   }
 
   function users(this: any) {
-    this.use('users', memory(getInitDb('users')));
+    this.use('users', new MemoryService(getInitDb('users')));
   }
 
   function comments(this: any) {
-    this.use('comments', memory(getInitDb('comments')));
+    this.use('comments', new MemoryService(getInitDb('comments')));
   }
 
   function posts(this: any) {
-    this.use('posts', memory(getInitDb('posts')));
+    this.use('posts', new MemoryService(getInitDb('posts')));
   }
 
   function recommendation(this: any) {
-    this.use('recommendation', memory(getInitDb('recommendation')));
+    this.use('recommendation', new MemoryService(getInitDb('recommendation')));
   }
 }

test/helpers/config-app.ts

@@ -3,7 +3,7 @@ import { feathers } from '@feathersjs/feathers';
 import BatchLoader from '@feathers-plus/batch-loader';
 // @ts-ignore
 import CacheMap from '@feathers-plus/cache';
-import { Service } from 'feathers-memory';
+import { MemoryService } from '@feathersjs/memory';
 import { cache, fastJoin, iff, makeCallingParams } from '../../src';
 
 const { getResultsByKey, getUniqueKeys } = BatchLoader;
@@ -54,7 +54,7 @@ function postsService(this: any) {
   const app = this;
   const store = clone(postsStoreInit);
 
-  class PostsService extends Service {
+  class PostsService extends MemoryService {
     foo: boolean;
 
     constructor(...args: any[]) {
@@ -81,7 +81,7 @@ function usersService(this: any) {
   const app = this;
   const store = clone(usersStoreInit);
 
-  class UsersService extends Service {
+  class UsersService extends MemoryService {
     junk: boolean;
     constructor(...args: any[]) {
       super(...args);

test/hooks/fast-join-cache.test.ts

@@ -1,6 +1,6 @@
 import { assert } from 'chai';
 import { feathers } from '@feathersjs/feathers';
-import memory from 'feathers-memory';
+import { MemoryService } from '@feathersjs/memory';
 import { iff, populate } from '../../src';
 
 const userId = 6;
@@ -147,7 +147,7 @@ function user(this: any) {
 
   app.use(
     '/users',
-    memory({
+    new MemoryService({
       store: clone(userInit),
       startId: userId,
       paginate: {
@@ -173,7 +173,7 @@ function team(this: any) {
 
   app.use(
     '/teams',
-    memory({
+    new MemoryService({
       store: clone(teamInit),
       startId: teamId,
     })

test/hooks/populate-misc.test.ts

@@ -111,11 +111,13 @@ import { populate } from '../../src';
                 },
                 commentsInfo: [
                   {
+                    id: 1,
                     title: 'Comment 1',
                     content: 'Lorem ipsum dolor sit amet 1',
                     postId: 1,
                   },
                   {
+                    id: 3,
                     title: 'Comment 3',
                     content: 'Lorem ipsum dolor sit amet 3',
                     postId: 1,
@@ -177,11 +179,13 @@ import { populate } from '../../src';
                   },
                   commentsInfo: [
                     {
+                      id: 1,
                       title: 'Comment 1',
                       content: 'Lorem ipsum dolor sit amet 1',
                       postId: 1,
                     },
                     {
+                      id: 3,
                       title: 'Comment 3',
                       content: 'Lorem ipsum dolor sit amet 3',
                       postId: 1,
@@ -229,6 +233,7 @@ import { populate } from '../../src';
                   },
                   commentsInfo: [
                     {
+                      id: 2,
                       title: 'Comment 2',
                       content: 'Lorem ipsum dolor sit amet 2',
                       postId: 2,
@@ -276,11 +281,13 @@ import { populate } from '../../src';
                   },
                   commentsInfo: [
                     {
+                      id: 1,
                       title: 'Comment 1',
                       content: 'Lorem ipsum dolor sit amet 1',
                       postId: 1,
                     },
                     {
+                      id: 3,
                       title: 'Comment 3',
                       content: 'Lorem ipsum dolor sit amet 3',
                       postId: 1,

test/hooks/populate-relations.test.ts

@@ -1,6 +1,6 @@
 import assert from 'assert';
 import { feathers } from '@feathersjs/feathers';
-import memory from 'feathers-memory';
+import { MemoryService } from '@feathersjs/memory';
 import { setField } from '../../src';
 
 import type { Application } from '@feathersjs/feathers';
@@ -15,7 +15,7 @@ describe('setField', () => {
 
   beforeEach(async () => {
     app = feathers();
-    app.use('/messages', memory());
+    app.use('/messages', new MemoryService());
     app.service('messages').hooks({
       before: {
         all: [
@@ -65,19 +65,6 @@ describe('setField', () => {
     );
   });
 
-  it('errors when used with wrong app version', async () => {
-    app.version = '3.2.1';
-
-    await assert.rejects(
-      async () => {
-        await app.service('messages').get('testing');
-      },
-      {
-        message: "The 'setField' hook only works with Feathers 4 and the latest database adapters",
-      }
-    );
-  });
-
   it('find queries with user information, does not modify original objects', async () => {
     const query = {};
     // @ts-ignore

test/hooks/set-field.test.ts

@@ -1,6 +1,6 @@
 import assert from 'assert';
 import { feathers } from '@feathersjs/feathers';
-import memory from 'feathers-memory';
+import { MemoryService } from '@feathersjs/memory';
 import { softDelete } from '../../src';
 
 const initialUsers = [
@@ -18,7 +18,7 @@ describe('services softDelete', () => {
   beforeEach(() => {
     const app = feathers().use(
       '/users',
-      memory({
+      new MemoryService({
         multi: ['create', 'patch', 'remove'],
       })
     );
@@ -33,22 +33,6 @@ describe('services softDelete', () => {
     userService.create(initialUsers);
   });
 
-  it('throws error on wrong app version', async () => {
-    const app = feathers().use('/users', memory());
-
-    app.service('users').hooks({
-      before: {
-        all: [softDelete()],
-      },
-    });
-
-    app.version = '3.1.4';
-
-    await assert.rejects(() => app.service('users').find(), {
-      message: 'The softDelete hook requires Feathers 4.0.0 or later',
-    });
-  });
-
   describe('find', () => {
     it('does not return deleted items', async () => {
       const users = await userService.find();
@@ -223,7 +207,7 @@ describe('services softDelete', () => {
     beforeEach(() => {
       const app = feathers().use(
         '/people',
-        memory({
+        new MemoryService({
           multi: ['create', 'patch', 'remove'],
         })
       );