Skip to content

ngDragClone: variables were undefined if project was wrapped with IIFE. #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

ngDragClone: variables were undefined if project was wrapped with IIFE. #216

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ce967a1
ngDragClone: variables were undefined if project was wrapped with IIFE.
Jan 25, 2016
ca777b5
Make allowTransform===false use clientX instead of pageX to calculate…
Aug 10, 2017
b4be0cc
Some comments. Renaming variables
Aug 10, 2017
036f134
Use spaces instead of tabs to indent
Aug 10, 2017
90029d5
Merge pull request #1 from Mreikon/master
Aug 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions ngDraggable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,17 @@ angular.module("ngDraggable", [])
_ty = _my - _mry - _dragOffset.top;
}

moveElement(_tx, _ty);
if(allowTransform)
moveElement(_tx, _ty);
else{
//Note: does not take into account _centerAnchor
//Click offset in element coordinates
var ty = _mry - _dragOffset.top;
var tx = _mrx - _dragOffset.left;
var newX = ngDraggable.inputEvent(evt).clientX - tx;
var newY = ngDraggable.inputEvent(evt).clientY - ty;
moveElement(newX, newY);
}

$rootScope.$broadcast('draggable:move', { x: _mx, y: _my, tx: _tx, ty: _ty, event: evt, element: element, data: _data, uid: _myid, dragOffset: _dragOffset });
};
Expand Down Expand Up @@ -254,7 +264,7 @@ angular.module("ngDraggable", [])
'-ms-transform': 'matrix(1, 0, 0, 1, ' + x + ', ' + y + ')'
});
}else{
element.css({'left':x+'px','top':y+'px', 'position':'fixed'});
element.css({'left': x+'px','top': y+'px', 'position': 'fixed', 'z-index': 99999});
}
};
initialize();
Expand Down Expand Up @@ -393,7 +403,7 @@ angular.module("ngDraggable", [])
return {
restrict: 'A',
link: function (scope, element, attrs) {
var img, _allowClone=true;
var img, _allowClone=true, _tx, _ty;
var _dragOffset = null;
scope.clonedData = {};
var initialize = function () {
Expand Down