Skip to content

Commit 2ddb680

Browse files
hmdrosJuanVqz
andauthored
Add ruby 3.4 CI and gem base64 listed (#124)
* Add changelog to report ruby 3.4 compatibility * Add ruby 3.4 CI and gem base64 listed * base64 gemspec constraint * Removing VCR gem * Rubocop regen todo file * Remove WebMock net connection restriction in test_helper.rb --------- Co-authored-by: Juan Vásquez <juan@ombulabs.com>
1 parent 5380532 commit 2ddb680

File tree

8 files changed

+12
-75
lines changed

8 files changed

+12
-75
lines changed

.github/workflows/main.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
strategy:
1010
matrix:
1111
os: [ubuntu]
12-
ruby-version: ["2.6", "2.7", "3.0", "3.1", "3.2", "3.3"]
12+
ruby-version: ["2.6", "2.7", "3.0", "3.1", "3.2", "3.3", "3.4"]
1313
steps:
1414
- uses: actions/checkout@v2
1515
- name: Setup Ruby ${{ matrix.ruby-version }}
@@ -19,6 +19,6 @@ jobs:
1919
bundler-cache: true
2020
- name: Build and run tests
2121
run: |
22-
gem install bundler -v 2.4.6
22+
gem install bundler -v 2.4.22
2323
bundle install --jobs 4 --retry 3
2424
bundle exec rake

.rubocop_todo.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# This configuration was generated by
22
# `rubocop --auto-gen-config`
3-
# on 2025-10-09 00:04:06 UTC using RuboCop version 1.81.1.
3+
# on 2025-10-17 11:20:00 UTC using RuboCop version 1.81.1.
44
# The point is for the user to remove these configuration records
55
# one by one as the offenses are removed from the code base.
66
# Note that changes in the inspected code, or installation of new
@@ -40,7 +40,7 @@ Metrics/AbcSize:
4040
# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
4141
# AllowedMethods: refine
4242
Metrics/BlockLength:
43-
Max: 79
43+
Max: 82
4444

4545
# Offense count: 2
4646
# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
99

1010
* [FEATURE: Add Skunk HTML Report](https://github.com/fastruby/skunk/pull/123)
1111
* [FEATURE: Add Skunk::Config class](https://github.com/fastruby/skunk/pull/123)
12+
* [FEATURE: Add Ruby 3.4 compatibility](https://github.com/fastruby/skunk/pull/124)
1213

1314
## v0.5.4 / 2025-05-05 [(commits)](https://github.com/fastruby/skunk/compare/v0.5.3...v0.5.4)
1415

Gemfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,3 @@ gemspec
99

1010
gem "reek", "~> 6.1"
1111
gem "rubocop", "~> 1.48"
12-
gem "vcr", "~> 6.1.0"

skunk.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,5 +52,5 @@ Gem::Specification.new do |spec|
5252
spec.add_development_dependency "rubocop"
5353
spec.add_development_dependency "simplecov", "~> 0.18"
5454
spec.add_development_dependency "simplecov-console", "0.5.0"
55-
spec.add_development_dependency "webmock", "~> 3.10.0"
55+
spec.add_development_dependency "webmock", "~> 3.20.0"
5656
end

test/lib/skunk/application_test.rb

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,9 +75,12 @@
7575
end
7676

7777
around do |example|
78-
VCR.use_cassette "skunk-fyi" do
79-
example.call
80-
end
78+
stub_request(:post, "https://skunk.fastruby.io/reports").to_return(
79+
status: 200,
80+
body: '{"id":"j"}',
81+
headers: { "Content-Type" => "application/json" }
82+
)
83+
example.call
8184
end
8285

8386
it "share report to default server" do

test/samples/vcr/skunk-fyi.yml

Lines changed: 0 additions & 59 deletions
This file was deleted.

test/test_helper.rb

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
require "minitest/around/spec"
2727
require "minitest/stub_any_instance"
2828
require "webmock/minitest"
29-
require "vcr"
3029

3130
require "skunk/rubycritic/analysed_module"
3231

@@ -52,9 +51,3 @@ def capture_output_streams
5251
$stdout = STDOUT
5352
$stderr = STDERR
5453
end
55-
56-
VCR.configure do |config|
57-
config.hook_into :webmock
58-
config.allow_http_connections_when_no_cassette = false
59-
config.cassette_library_dir = "test/samples/vcr"
60-
end

0 commit comments

Comments
 (0)