send Basecamp messages from sentry webhook Handling

Author: nvo87

requirements.in

@@ -2,3 +2,4 @@ fastapi[all]
 pytest
 pip-tools
 pytest-httpx
+pytest-mock

requirements.txt

@@ -74,8 +74,11 @@ pytest==7.2.0
     # via
     #   -r requirements.in
     #   pytest-httpx
+    #   pytest-mock
 pytest-httpx==0.21.2
     # via -r requirements.in
+pytest-mock==3.10.0
+    # via -r requirements.in
 python-dotenv==0.21.0
     # via uvicorn
 python-multipart==0.0.5

src/basecamp/__init.py__

@@ -7,10 +7,12 @@
 
 
 class CampfireBot:
-    def send_message(self, message: str) -> Response:
+
+    @staticmethod
+    def send_message(message: str) -> Response:
         """ https://github.com/basecamp/bc3-api/blob/master/sections/chatbots.md#create-a-line """
 
-        url = f'https://3.basecampapi.com/{settings.BASECAMP_ACCOUNT_ID}/integrations/{settings.BASECAMP_CHATBOT_KEY}/buckets/1/chats/2/lines.json'
+        url = f'https://3.basecampapi.com/{settings.BASECAMP_ACCOUNT_ID}/integrations/{settings.BASECAMP_CHATBOT_KEY}/buckets/{settings.BASECAMP_PROJECT_ID}/chats/{settings.BASECAMP_CHAT_ID}/lines.json'
 
         response = httpx.post(url, data={'content': message})
         response.raise_for_status()

src/basecamp/campfire_bot.py

@@ -10,6 +10,8 @@ class Settings(BaseSettings):
 
     BASECAMP_ACCOUNT_ID: str = 'bc-acc-id'
     BASECAMP_CHATBOT_KEY: str = 'bc-bot-key'
+    BASECAMP_PROJECT_ID: int = 111
+    BASECAMP_CHAT_ID: int = 111
 
     class Config:
         env_file = 'src/.env'

src/config.py

@@ -4,24 +4,18 @@
 from fastapi import status
 from fastapi import APIRouter
 
-from sentry.types import Webhook
-
+from basecamp.campfire_bot import CampfireBot
+from sentry.models import Webhook
 
 api_router = APIRouter()
 
 
 @api_router.post("/api/sentry/webhook", status_code=status.HTTP_200_OK)
 async def sentry_webhook(webhook: Webhook, request: Request):
-    if request.headers.get('sentry-hook-resource') == 'issue':
-
-        #todo send webhook.data.get('title') to the Basecamp
-
-        return 'ok!'
-
-    elif request.headers.get('sentry-hook-resource') == 'event-alert':
-
-        return 'ok!'
+    sentry_hook_resource = request.headers.get('sentry-hook-resource')
 
+    if sentry_hook_resource in ['issue', 'event-alert']:
+        message = webhook.dispatch_webhook_title(sentry_hook_resource)
+        CampfireBot.send_message(message)
     else:
-
         return Response(status_code=status.HTTP_400_BAD_REQUEST)

src/sentry/api.py

@@ -13,3 +13,11 @@ class Webhook(BaseModel, extra=Extra.allow):
     action: str
     data: Mapping[str, Any]
     installation: Installation
+
+    def dispatch_webhook_title(self, sentry_hook_resource: str) -> str:
+        hook_title = {
+            'issue': lambda: self.data['issue']['title'],
+            'event-alert': lambda: self.data['event']['title'],
+        }
+
+        return hook_title.get(sentry_hook_resource)()

src/sentry/types.py renamed to src/sentry/models.py

@@ -1,7 +1,7 @@
 import pytest
 from fastapi.testclient import TestClient
 from main import app
-from sentry.tests.request_data import event, issue
+from sentry.tests.mocked_request_data import event, issue
 
 
 @pytest.fixture

src/sentry/tests/conftest.py

@@ -1,14 +1,24 @@
+import pytest
 
-def test_response_if_issue(client, issue_resolved_webhook, headers):
+
+@pytest.fixture
+def mocked_basecamp_send_message(mocker):
+    return mocker.patch('basecamp.campfire_bot.CampfireBot.send_message')
+
+
+def test_response_if_issue(client, issue_resolved_webhook, headers, mocked_basecamp_send_message):
     response = client.post('/api/sentry/webhook', json=issue_resolved_webhook, headers=headers)
 
     assert response.status_code == 200
+    mocked_basecamp_send_message.assert_called_once()
 
 
-def test_response_if_alert(client, alert_triggered_webhook, headers):
+def test_response_if_alert(client, alert_triggered_webhook, headers, mocked_basecamp_send_message):
+    headers['sentry-hook-resource'] = 'event-alert'
     response = client.post('/api/sentry/webhook', json=alert_triggered_webhook, headers=headers)
 
     assert response.status_code == 200
+    mocked_basecamp_send_message.assert_called_once()
 
 
 def test_bad_response_if_bad_headers(client, issue_resolved_webhook):