Moved the Assert.state(!completed) check out of ExecutionInternal.record(ExecutionResult)

Author: jhalterman

src/main/java/net/jodah/failsafe/AsyncExecutionImpl.java

@@ -93,6 +93,7 @@ public void record(R result, Throwable failure) {
     // Guard against race with a timeout expiring
     synchronized (future) {
       if (!attemptRecorded) {
+        Assert.state(!completed, "Execution has already been completed");
         record(new ExecutionResult<>(result, failure));
       }
 

src/main/java/net/jodah/failsafe/ExecutionImpl.java

@@ -128,8 +128,6 @@ public synchronized void recordAttempt() {
 
   @Override
   public synchronized void record(ExecutionResult<R> result) {
-    Assert.state(!completed, "Execution has already been completed");
-
     if (preExecuted && !attemptRecorded) {
       recordAttempt();
       executions.incrementAndGet();
@@ -144,6 +142,7 @@ public synchronized void record(ExecutionResult<R> result) {
    * @throws IllegalStateException if the execution is already complete
    */
   synchronized ExecutionResult<R> postExecute(ExecutionResult<R> result) {
+    Assert.state(!completed, "Execution has already been completed");
     record(result);
     boolean allComplete = true;
     for (PolicyExecutor<R, ? extends Policy<R>> policyExecutor : policyExecutors) {

src/main/java/net/jodah/failsafe/spi/ExecutionInternal.java

@@ -33,8 +33,6 @@ public interface ExecutionInternal<R> extends ExecutionContext<R> {
   /**
    * Records the {@code result} if the execution has been {@link #preExecute() pre-executed} and a result has not
    * already been recorded.
-   *
-   * @throws IllegalStateException if the execution is already complete
    */
   void record(ExecutionResult<R> result);