Minor code cleanup

Author: jhalterman

src/main/java/dev/failsafe/internal/TimedCircuitStats.java

@@ -34,6 +34,24 @@ class TimedCircuitStats implements CircuitStats {
   private final Stat summary;
   volatile int currentIndex;
 
+  public TimedCircuitStats(int bucketCount, Duration thresholdingPeriod, Clock clock, CircuitStats oldStats) {
+    this.clock = clock;
+    this.buckets = new Bucket[bucketCount];
+    bucketSizeMillis = thresholdingPeriod.toMillis() / buckets.length;
+    windowSizeMillis = bucketSizeMillis * buckets.length;
+    for (int i = 0; i < buckets.length; i++)
+      buckets[i] = new Bucket();
+    this.summary = new Stat();
+
+    if (oldStats == null) {
+      buckets[0].startTimeMillis = clock.currentTimeMillis();
+    } else {
+      synchronized (oldStats) {
+        copyStats(oldStats);
+      }
+    }
+  }
+
   static class Clock {
     long currentTimeMillis() {
       return System.currentTimeMillis();
@@ -85,24 +103,6 @@ public String toString() {
     }
   }
 
-  public TimedCircuitStats(int bucketCount, Duration thresholdingPeriod, Clock clock, CircuitStats oldStats) {
-    this.clock = clock;
-    this.buckets = new Bucket[bucketCount];
-    bucketSizeMillis = thresholdingPeriod.toMillis() / buckets.length;
-    windowSizeMillis = bucketSizeMillis * buckets.length;
-    for (int i = 0; i < buckets.length; i++)
-      buckets[i] = new Bucket();
-    this.summary = new Stat();
-
-    if (oldStats == null) {
-      buckets[0].startTimeMillis = clock.currentTimeMillis();
-    } else {
-      synchronized (oldStats) {
-        copyStats(oldStats);
-      }
-    }
-  }
-
   /**
    * Copies the most recent stats from the {@code oldStats} into this in order from oldest to newest and orders buckets
    * from oldest to newest, with uninitialized buckets counting as oldest.

src/main/java/dev/failsafe/internal/util/Lists.java

@@ -13,6 +13,9 @@ public final class Lists {
   private Lists() {
   }
 
+  /**
+   * Returns a list containing the {@code first} element followed by the {@code rest}.
+   */
   public static <T> List<T> of(T first, T[] rest) {
     List<T> result = new ArrayList<>(rest.length + 1);
     result.add(first);

src/test/java/dev/failsafe/internal/util/ListsTest.java

@@ -0,0 +1,29 @@
+/*
+ * Copyright 2021 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License
+ */
+package dev.failsafe.internal.util;
+
+import org.testng.annotations.Test;
+
+import java.util.Arrays;
+
+import static org.testng.Assert.assertEquals;
+
+@Test
+public class ListsTest {
+  public void testOf() {
+    assertEquals(Lists.of("a", new String[] { "b", "c" }), Arrays.asList("a", "b", "c"));
+  }
+}