Merge pull request #82 from reedsy/emit-undefined

🐛 Avoid emitting `undefined` as a return value

Author: ruojianll

src/option/emit.ts

@@ -28,7 +28,9 @@ export function build(cons: Cons, optionBuilder: OptionBuilder) {
                 const proRet = await ret
                 this.$emit(eventName, proRet)
             }
-            else {
+            else if (ret === undefined) {
+                this.$emit(eventName)
+            } else {
                 this.$emit(eventName, ret)
             }
         }

test/option/emit.ts

@@ -2,6 +2,7 @@
 import { expect } from 'chai';
 import 'mocha';
 import { Component, Emit, Base, toNative } from '../../dist'
+import {mount} from '@vue/test-utils';
 
 @Component
 class Comp extends Base {
@@ -25,6 +26,9 @@ class Comp extends Base {
         })
     }
 
+    @Emit
+    noReturn() {}
+
 }
 const CompContext = toNative(Comp) as any
 
@@ -73,6 +77,11 @@ describe('decorator Emit',
             expect(emitName).to.equal('promiseEmit')
             expect(emitValue).to.equal('promiseEmit value')
         })
+        it('has an empty array when emitting void', () => {
+            const component = mount(CompContext)
+            component.vm.noReturn()
+            expect(component.emitted('noReturn')).to.eql([[]])
+        })
     }
 )
 export default {}