Merge pull request #261 from facebookresearch/pr/reduction1D

 Fix and reactivate 1-D reduction tests

Author: nicolasvasilache

include/tc/core/utils/dlpack-inl.h

@@ -109,6 +109,9 @@ inline void SetStrides(DLTensor& t, const std::vector<int64_t>& strides) {
 
 inline void SetStridesFromSizes(DLTensor& t, const std::vector<int64_t>&) {
   auto ndim = t.ndim;
+  if (ndim == 0) {
+    return;
+  }
   t.strides[ndim - 1] = 1;
   for (int i = ndim - 2; i >= 0; --i) {
     t.strides[i] = t.strides[i + 1] * t.shape[i + 1];

test/test_tc_mapper.cc

@@ -139,30 +139,30 @@ TEST_F(TcMapper1DReductionTest, DISABLED_Reduction1Dv0) {
   Check(A, mappingOptions, 0);
 }
 
-TEST_F(TcMapper1DReductionTest, DISABLED_Reduction1Dv1) {
+TEST_F(TcMapper1DReductionTest, Reduction1Dv1) {
   auto mappingOptions = tc::CudaMappingOptions::makeNaiveCudaMappingOptions()
                             .tile(0)
-                            .mapToBlocks({})
+                            .mapToBlocks({1})
                             .mapToThreads({16});
   LOG(INFO) << mappingOptions << endl;
   at::Tensor A = at::CUDA(at::kFloat).rand({M});
   Check(A, mappingOptions, 1);
 }
 
-TEST_F(TcMapper1DReductionTest, DISABLED_Reduction1Dv2) {
+TEST_F(TcMapper1DReductionTest, Reduction1Dv2) {
   auto mappingOptions = tc::CudaMappingOptions::makeNaiveCudaMappingOptions()
                             .tile(0)
-                            .mapToBlocks({})
+                            .mapToBlocks({1})
                             .mapToThreads({16});
   LOG(INFO) << mappingOptions << endl;
   at::Tensor A = at::CUDA(at::kFloat).rand({M});
   Check(A, mappingOptions, 2);
 }
 
-TEST_F(TcMapper1DReductionTest, DISABLED_Reduction1Dv3) {
+TEST_F(TcMapper1DReductionTest, Reduction1Dv3) {
   auto mappingOptions = tc::CudaMappingOptions::makeNaiveCudaMappingOptions()
                             .tile(0)
-                            .mapToBlocks({})
+                            .mapToBlocks({1})
                             .mapToThreads({16});
   LOG(INFO) << mappingOptions << endl;
   at::Tensor A = at::CUDA(at::kFloat).rand({M});