Merge pull request #229 from facebookresearch/log-changes

Remove the flags check for logging in two places

Author: nicolasvasilache

src/autotuner/genetic_tuning_harness.cc

@@ -326,13 +326,11 @@ void GeneticTunerHarness::doCompile(ExecutorType& engine) {
       pConf->optionalCompilationHandle =
           std::unique_ptr<size_t>(new size_t(handle));
     } catch (const std::exception& e) {
-      if (FLAGS_debug_tuner) {
-        LOG(WARNING) << "[TUNER][COMPILE] failed compilation: " << e.what();
-        std::stringstream ssWarning;
-        MappingOptionsCppPrinter warningPrinter(ssWarning);
-        warningPrinter << options;
-        LOG_LINE_BY_LINE(WARNING, ssWarning);
-      }
+      LOG(WARNING) << "[TUNER][COMPILE] failed compilation: " << e.what();
+      std::stringstream ssWarning;
+      MappingOptionsCppPrinter warningPrinter(ssWarning);
+      warningPrinter << options;
+      LOG_LINE_BY_LINE(WARNING, ssWarning);
       pConf->invalid = true;
     }
     CHECK(pConf->invalid || pConf->optionalCompilationHandle)
@@ -413,14 +411,12 @@ void GeneticTunerHarness::doGpuWork(
         engine.clear(handle);
       }
     } catch (std::exception& e) {
-      if (FLAGS_debug_tuner) {
-        LOG(WARNING) << "Runtime error gpu " << gpu << ": " << e.what();
-        std::stringstream ssWarning;
-        MappingOptionsCppPrinter warningPrinter(ssWarning);
-        warningPrinter << options;
-        LOG(WARNING) << "Aborted execution on gpu " << gpu;
-        LOG_LINE_BY_LINE(WARNING, ssWarning);
-      }
+      LOG(WARNING) << "Runtime error gpu " << gpu << ": " << e.what();
+      std::stringstream ssWarning;
+      MappingOptionsCppPrinter warningPrinter(ssWarning);
+      warningPrinter << options;
+      LOG(WARNING) << "Aborted execution on gpu " << gpu;
+      LOG_LINE_BY_LINE(WARNING, ssWarning);
       while (cudaGetLastError() != cudaSuccess) {
         // In case of errors in the generated, we cannot rely on deviceReset to
         // set the GPU in a clean state. So instead we just pop and discard all

src/core/cuda/cuda_tc_executor.cc

@@ -174,9 +174,7 @@ void CudaTcExecutor::compileWithTcMapper() {
   // that.
   std::tie(cudaSource, grid, block) =
       mappedScop->codegen(kernelSpecializedName);
-  if (FLAGS_dump_cuda) {
-    std::cout << "generatedCuda: " << cudaSource << std::endl;
-  }
+  LOG_IF(INFO, FLAGS_dump_cuda) << "generatedCuda: " << cudaSource;
 }
 
 Duration CudaTcExecutor::run(