Remove AsMut on Hashed

ndmitchell · facebook-github-bot · commit 6327eea9d087 · 2024-07-13T12:43:44.000-07:00
Summary: This breaks the invariants, allowing someone to mutate the inside and thus break the hash.

Reviewed By: JakobDegen

Differential Revision: D59722733

fbshipit-source-id: 065e5251bc0a0345ee6029206bf2784ffdb563ef
diff --git a/gazebo/src/hash.rs b/gazebo/src/hash.rs
@@ -56,12 +56,6 @@ impl<T> AsRef<T> for Hashed<T> {
     }
 }
 
-impl<T> AsMut<T> for Hashed<T> {
-    fn as_mut(&mut self) -> &mut T {
-        &mut self.value
-    }
-}
-
 impl<T: Hash> From<T> for Hashed<T> {
     fn from(value: T) -> Self {
         Self::new(value)

Original file line number	Diff line number	Diff line change
`@@ -56,12 +56,6 @@ impl<T> AsRef<T> for Hashed<T> {`
`56`	`56`	`}`
`57`	`57`	`}`
`58`	`58`
`59`		`-impl<T> AsMut<T> for Hashed<T> {`
`60`		`- fn as_mut(&mut self) -> &mut T {`
`61`		`- &mut self.value`
`62`		`- }`
`63`		`-}`
`64`		`-`
`65`	`59`	`impl<T: Hash> From<T> for Hashed<T> {`
`66`	`60`	`fn from(value: T) -> Self {`
`67`	`61`	`Self::new(value)`