-
Notifications
You must be signed in to change notification settings - Fork 7
Run test #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Run test #4
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| name: Tests | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| push: | ||
| branches: | ||
| - main | ||
|
|
||
| jobs: | ||
| build-and-test: | ||
| runs-on: macos-latest | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Swift | ||
| uses: swift-actions/setup-swift@v2 | ||
| with: | ||
| swift-version: '6.0' | ||
|
|
||
| - name: Build | ||
| run: swift build --build-tests | ||
|
|
||
| - name: Run tests | ||
| run: swift test |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,28 +21,21 @@ let package = Package( | |
| name: "QuickLayout", | ||
| targets: ["QuickLayout"] | ||
| ), | ||
| .library( | ||
| name: "QuickLayoutCore", | ||
| targets: ["QuickLayoutCore"] | ||
| ), | ||
| .library( | ||
| name: "FastResultBuilder", | ||
| targets: ["FastResultBuilder"] | ||
| ), | ||
| .library( | ||
| name: "QuickLayoutBridge", | ||
| targets: ["QuickLayoutBridge"] | ||
| ), | ||
| ], | ||
| dependencies: [ | ||
| .package(url: "https://github.com/apple/swift-syntax.git", from: "600.0.0") | ||
| .package(url: "https://github.com/apple/swift-syntax.git", from: "602.0.0"), | ||
| .package(url: "https://github.com/pointfreeco/swift-macro-testing.git", from: "0.6.4"), | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is this package for?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's a third-party tool to simplify Macro testing. While the library looks interesting and perhaps helpful, it's a third-party dependency which we might not have at Meta. Until, there are heavy reasons, I would prefer QuickLayout stick to vanilla Apple frameworks. Could you please remove it? Thank you. |
||
| ], | ||
| targets: [ | ||
| .target( | ||
| name: "QuickLayout", | ||
| dependencies: [ | ||
| "QuickLayoutMacro", | ||
| "QuickLayoutBridge", | ||
| .target(name: "QuickLayoutBridge", condition: .when(platforms: [.iOS])), | ||
| ], | ||
| path: "Sources/QuickLayout/QuickLayout", | ||
| exclude: [ | ||
|
|
@@ -55,11 +48,11 @@ let package = Package( | |
| .product(name: "SwiftSyntaxMacros", package: "swift-syntax"), | ||
| .product(name: "SwiftCompilerPlugin", package: "swift-syntax"), | ||
| ], | ||
| path: "Sources/QuickLayout/QuickLayoutMacro", | ||
| path: "Sources/QuickLayout/QuickLayoutMacro" | ||
| ), | ||
| .target( | ||
| name: "QuickLayoutCore", | ||
| path: "Sources/QuickLayout/QuickLayoutCore", | ||
| path: "Sources/QuickLayout/QuickLayoutCore" | ||
| ), | ||
| .target( | ||
| name: "FastResultBuilder", | ||
|
|
@@ -70,12 +63,23 @@ let package = Package( | |
| ), | ||
| .target( | ||
| name: "QuickLayoutBridge", | ||
| dependencies: ["FastResultBuilder", "QuickLayoutCore"], | ||
| dependencies: [ | ||
| "FastResultBuilder", | ||
| .target(name: "QuickLayoutCore", condition: .when(platforms: [.iOS])), | ||
| ], | ||
| path: "Sources/QuickLayout/QuickLayoutBridge", | ||
| exclude: [ | ||
| "__server_snapshot_tests__", | ||
| "__tests__", | ||
| ] | ||
| ), | ||
| ], | ||
| .testTarget( | ||
| name: "QuickLayoutMacroTests", | ||
| dependencies: [ | ||
| "QuickLayoutMacro", | ||
| .product(name: "SwiftSyntaxMacrosTestSupport", package: "swift-syntax"), | ||
| ], | ||
| path: "Sources/QuickLayout/QuickLayoutMacroTests" | ||
| ) | ||
| ] | ||
| ) | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version was dropped from 600 to 602 in the pervious pull request https://github.com/facebookincubator/QuickLayout/pull/3/files from @JonyFang.
What features do you need from 602 to support for this pull request?