Merge pull request #526 from EmanueleMinotto/best-practice

headers type + empty function

Author: gfosco

src/Facebook/HttpClients/FacebookStream.php

@@ -41,7 +41,7 @@ class FacebookStream
     /**
      * @var array Response headers from the stream wrapper
      */
-    protected $responseHeaders;
+    protected $responseHeaders = [];
 
     /**
      * Make a new context stream reference instance
@@ -56,7 +56,7 @@ public function streamContextCreate(array $options)
     /**
      * The response headers from the stream wrapper
      *
-     * @return array|null
+     * @return array
      */
     public function getResponseHeaders()
     {
@@ -73,7 +73,7 @@ public function getResponseHeaders()
     public function fileGetContents($url)
     {
         $rawResponse = file_get_contents($url, false, $this->stream);
-        $this->responseHeaders = $http_response_header;
+        $this->responseHeaders = $http_response_header ?: [];
 
         return $rawResponse;
     }

src/Facebook/HttpClients/FacebookStreamHttpClient.php

@@ -66,7 +66,7 @@ public function send($url, $method, $body, array $headers, $timeOut)
         $rawBody = $this->facebookStream->fileGetContents($url);
         $rawHeaders = $this->facebookStream->getResponseHeaders();
 
-        if ($rawBody === false || !$rawHeaders) {
+        if ($rawBody === false || empty($rawHeaders)) {
             throw new FacebookSDKException('Stream returned an empty response', 660);
         }
 

src/Facebook/Url/FacebookUrlManipulator.php

@@ -76,7 +76,7 @@ public static function removeParamsFromUrl($url, array $paramsToFilter)
      */
     public static function appendParamsToUrl($url, array $newParams = [])
     {
-        if (!$newParams) {
+        if (empty($newParams)) {
             return $url;
         }