Return Result from Evaluator::enable_profile

Summary: Following diff D38527560 starts validating arguments/state.

Reviewed By: bobyangyf

Differential Revision: D38523949

fbshipit-source-id: 237d964d3db0f24da243129d89c9755e4dde9fcf

Author: stepancheg

starlark/src/environment/modules.rs

@@ -506,7 +506,8 @@ mod tests {
     fn test_gen_heap_summary_profile() {
         let module = Module::new();
         let mut eval = Evaluator::new(&module);
-        eval.enable_profile(&ProfileMode::HeapSummaryRetained);
+        eval.enable_profile(&ProfileMode::HeapSummaryRetained)
+            .unwrap();
         eval.eval_module(
             AstModule::parse(
                 "x.star",

starlark/src/eval/runtime/evaluator.rs

@@ -211,7 +211,7 @@ impl<'v, 'a> Evaluator<'v, 'a> {
     /// Enable profiling, allowing [`Evaluator::write_profile`] to be used.
     /// Profilers add overhead, and while some profilers can be used together,
     /// it's better to run at most one profiler at a time.
-    pub fn enable_profile(&mut self, mode: &ProfileMode) {
+    pub fn enable_profile(&mut self, mode: &ProfileMode) -> anyhow::Result<()> {
         match mode {
             ProfileMode::HeapSummary
             | ProfileMode::HeapFlame
@@ -247,13 +247,14 @@ impl<'v, 'a> Evaluator<'v, 'a> {
                 self.typecheck_profile.enabled = true;
             }
         }
+        Ok(())
     }
 
     /// Enable instrumentation in module which is loaded by a module to be profiled.
     ///
     /// This function need to be called when evaluating a dependency of a module, if a module
     /// does profiling in the given mode.
-    pub fn enable_profile_instrumentation(&mut self, mode: &ProfileMode) {
+    pub fn enable_profile_instrumentation(&mut self, mode: &ProfileMode) -> anyhow::Result<()> {
         match mode {
             ProfileMode::Bytecode | ProfileMode::BytecodePairs => {
                 self.bc_profile.enable_1();
@@ -270,6 +271,7 @@ impl<'v, 'a> Evaluator<'v, 'a> {
             }
             ProfileMode::Typecheck => {}
         }
+        Ok(())
     }
 
     /// Write a profile to a file.

starlark/src/eval/runtime/profile/bc.rs

@@ -203,7 +203,7 @@ mod tests {
         let module = Module::new();
         let globals = Globals::standard();
         let mut eval = Evaluator::new(&module);
-        eval.enable_profile(&ProfileMode::Bytecode);
+        eval.enable_profile(&ProfileMode::Bytecode).unwrap();
         eval.eval_module(
             AstModule::parse("bc.star", "repr([1, 2])".to_owned(), &Dialect::Standard).unwrap(),
             &globals,
@@ -222,7 +222,7 @@ mod tests {
         let module = Module::new();
         let globals = Globals::standard();
         let mut eval = Evaluator::new(&module);
-        eval.enable_profile(&ProfileMode::BytecodePairs);
+        eval.enable_profile(&ProfileMode::BytecodePairs).unwrap();
         eval.eval_module(
             AstModule::parse("bc.star", "repr([1, 2])".to_owned(), &Dialect::Standard).unwrap(),
             &globals,

starlark/src/eval/runtime/profile/heap.rs

@@ -113,7 +113,7 @@ f
         let globals = Globals::standard();
         let module = Module::new();
         let mut eval = Evaluator::new(&module);
-        eval.enable_profile(&ProfileMode::HeapSummary);
+        eval.enable_profile(&ProfileMode::HeapSummary).unwrap();
         let f = eval.eval_module(ast, &globals)?;
         // first check module profiling works
         HeapProfile::write_summarized_heap_profile(module.heap());
@@ -122,7 +122,7 @@ f
         // second check function profiling works
         let module = Module::new();
         let mut eval = Evaluator::new(&module);
-        eval.enable_profile(&ProfileMode::HeapSummary);
+        eval.enable_profile(&ProfileMode::HeapSummary).unwrap();
         eval.eval_function(f, &[Value::new_int(100)], &[])?;
         HeapProfile::write_summarized_heap_profile(module.heap());
         HeapProfile::write_flame_heap_profile(module.heap());
@@ -131,7 +131,7 @@ f
         let module = Module::new();
         let mut eval = Evaluator::new(&module);
         module.heap().alloc("Thing that goes before");
-        eval.enable_profile(&ProfileMode::HeapSummary);
+        eval.enable_profile(&ProfileMode::HeapSummary).unwrap();
         eval.eval_function(f, &[Value::new_int(100)], &[])?;
         module.heap().alloc("Thing that goes after");
         HeapProfile::write_summarized_heap_profile(module.heap());

starlark/src/eval/runtime/profile/stmt.rs

@@ -224,7 +224,7 @@ xx(*[2])
             &Dialect::Extended,
         )
         .unwrap();
-        eval.enable_profile(&ProfileMode::Statement);
+        eval.enable_profile(&ProfileMode::Statement).unwrap();
         let mut globals = GlobalsBuilder::standard();
         test_functions(&mut globals);
         eval.eval_module(module, &globals.build()).unwrap();

starlark/src/eval/runtime/profile/typecheck.rs

@@ -92,7 +92,7 @@ def g():
 g()
 "#;
         let program = AstModule::parse("test.star", program.to_owned(), &Dialect::Extended)?;
-        eval.enable_profile(&ProfileMode::Typecheck);
+        eval.enable_profile(&ProfileMode::Typecheck)?;
         eval.eval_module(program, &Globals::extended())?;
 
         let csv = eval.typecheck_profile.gen_csv();

starlark/src/values/layout/heap/profile/summary.rs

@@ -200,7 +200,7 @@ _ignore = str([1])     # allocate a string in non_drop
         let globals = Globals::standard();
         let module = Module::new();
         let mut eval = Evaluator::new(&module);
-        eval.enable_profile(&ProfileMode::HeapSummary);
+        eval.enable_profile(&ProfileMode::HeapSummary).unwrap();
 
         eval.eval_module(ast, &globals).unwrap();