fix [Hover][Docstring] Docstrings from .py on attributes when base type is from .pyi #1090 #1520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
thanks for implementing this! I like the approach a lot. I'll be landing it soon with some modifications, namely moving it up into definition so it works on go-to definition + hover |
meta-codesync bot
pushed a commit
that referenced
this pull request
Nov 12, 2025
Summary: D80145015 implemented .py preference on go-to definition, but it did not work for attributes. that's because when we solve a type `a`, `a.attribute` doesn't do another find, it simply goes to the definition of a from solving which is always the .pyi. asuka implemented a fix for that [here](#1520) for hover docstrings. the intution is to do a second find on attribute definition lookup and look at the AST to find the corresponding definition. this works pretty well, and this diff stack generalizes it to definition. Reviewed By: connernilsen Differential Revision: D86814372 fbshipit-source-id: 8b7ed56d74071db55188d448f1eb76f91bcc612d
Contributor
|
landed as 4451507 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1090
FindDefinitionItemWithDocstring now tracks an optional docstring_module, attribute fallback searches the executable .py counterpart (loading the module if needed), and records docstrings even when the definition came from a .pyi. The class/assignment context detection was tightened so nested members are resolved reliably.
Hover responses now read docstrings from the recorded module, so the rendered markdown includes the implementation docstring while keeping go‑to-definition on the stub.