Skip to content

Commit f109280

Browse files
george-reynyafacebook-github-bot
authored andcommitted
Revert "innodb: Add thd_wait_begin/end for Sync IO"
Summary: This reverts commit 721fbd6. The stall mentioned in the commit above already has DISKIO wait begin/end in `buf_read_page_low`. So this extra DISKIO wait is not needed for that. However, this API is also used to write to the log on the commit code path while the binlog mutex is held, which causes lots of commit stalls. Differential Revision: D56561026 fbshipit-source-id: 868bc18
1 parent fdf68f7 commit f109280

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

storage/innobase/os/os0file.cc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
8787
#include "my_rnd.h"
8888
#include "mysql/service_mysql_keyring.h"
8989
#include "mysqld.h"
90-
#include "mysys/mysys_priv.h"
9190

9291
#include <sys/types.h>
9392
#include <zlib.h>
@@ -2047,7 +2046,6 @@ static file::Block *os_file_encrypt_log(const IORequest &type, void *&buf,
20472046
@return the number of bytes read/written or negative value on error */
20482047
ssize_t SyncFileIO::execute(const IORequest &request) {
20492048
ssize_t n_bytes;
2050-
My_thd_wait_scope wait(THD_WAIT_DISKIO);
20512049

20522050
if (request.is_read()) {
20532051
n_bytes = pread(m_fh, m_buf, m_n, m_offset);

0 commit comments

Comments
 (0)