Fix memory leak in i_s_innodb_tablespaces_fill_table (#1380)

Summary:
Looks like when space is 0, we forgot to release memory.

Following innodb code, after finish works, then call release heap memory at end

Pull Request resolved: #1380

Test Plan: MTR under asan build

Differential Revision: D50746754

fbshipit-source-id: cb7f7d4c420df3fbb2a7ab28c477cbec92a095a7

Author: luqun

storage/innobase/handler/i_s.cc

@@ -7108,14 +7108,13 @@ static int i_s_innodb_tablespaces_fill_table(THD *thd, TABLE_LIST *tables,
   heap = mem_heap_create(1000);
 
   if (dd_access_through_server()) {
-    return for_all_innodb_objects_in_dd<dd::Tablespace>(
+    int result = for_all_innodb_objects_in_dd<dd::Tablespace>(
         thd, [&heap, &tables](THD *thd, const dd::Tablespace &tablespace) {
           const auto &se_private_data = tablespace.se_private_data();
 
           space_id_t space;
           if (se_private_data.get(dd_space_key_strings[DD_SPACE_ID], &space)) {
             assert(false);
-            mem_heap_free(heap);
             return 1;
           }
 
@@ -7132,15 +7131,13 @@ static int i_s_innodb_tablespaces_fill_table(THD *thd, TABLE_LIST *tables,
           if (se_private_data.get(dd_space_key_strings[DD_SPACE_FLAGS],
                                   &flags)) {
             assert(false);
-            mem_heap_free(heap);
             return 1;
           }
 
           dd::String_type encryption;
           if (properties.exists("encryption") &&
               properties.get("encryption", &encryption)) {
             assert(false);
-            mem_heap_free(heap);
             return 1;
           }
 
@@ -7155,15 +7152,13 @@ static int i_s_innodb_tablespaces_fill_table(THD *thd, TABLE_LIST *tables,
           if (se_private_data.get(dd_space_key_strings[DD_SPACE_SERVER_VERSION],
                                   &server_version)) {
             assert(false);
-            mem_heap_free(heap);
             return 1;
           }
 
           uint32 space_version;
           if (se_private_data.get(dd_space_key_strings[DD_SPACE_VERSION],
                                   &space_version)) {
             assert(false);
-            mem_heap_free(heap);
             return 1;
           }
 
@@ -7172,15 +7167,13 @@ static int i_s_innodb_tablespaces_fill_table(THD *thd, TABLE_LIST *tables,
           if (se_private_data.get(dd_space_key_strings[DD_SPACE_STATE],
                                   &state)) {
             assert(false);
-            mem_heap_free(heap);
             return 1;
           }
 
           uint64_t autoextend_size = 0;
           if (properties.exists(autoextend_size_str) &&
               properties.get(autoextend_size_str, &autoextend_size)) {
             assert(false);
-            mem_heap_free(heap);
             return 1;
           }
 
@@ -7192,6 +7185,8 @@ static int i_s_innodb_tablespaces_fill_table(THD *thd, TABLE_LIST *tables,
 
           return 0;
         });
+    mem_heap_free(heap);
+    return result;
   }
 
   assert(!dd_access_through_server());