fix bypass sql fallback not reading columns

Summary:
when bypass falls back to mysql execution, bypass already made changes to the field object's state, mysql skipped setting `table->read_list` bit for some columns because of this. The storage engine does not read columns not set in the `table->read_list` bitmap.

- delay making changes to field object to the execution phase
- when there is error happen in execution phase, we will only fallback when m_unsupported is set, this happens before we make changes to field objects, so when fallback happens, field objects are in 'clean' state
- minor refactor in nosql_access.cc
- new test case of verifying data read in fallback scenarios

Reviewed By: luqun, jupyung

Differential Revision: D43201630

fbshipit-source-id: 677e42e

Author: bladepan

mysql-test/suite/rocksdb/include/bypass_create_table.inc

@@ -263,6 +263,14 @@ insert into link_table5 values (1, 1, 5, 2, 2, 1, 'data15', 1, 1);
 insert into link_table5 values (2, 1, 1, 2, 2, 1, 'data21', 1, 1);
 insert into link_table5 values (2, 1, 2, 2, 2, 1, 'data22', 1, 1);
 insert into link_table5 values (2, 1, 3, 2, 2, 1, 'data32', 1, 1);
+insert into link_table5 values
+  (100, 101, 102, 103, 104, 1, 'data100', 105, 106);
+insert into link_table5 values
+  (200, 201, 202, 203, 204, 2, 'data200', 205, 206);
+insert into link_table5 values
+  (300, 301, 302, 303, 304, 3, 'data300', 305, 306);
+insert into link_table5 values
+  (400, 401, 402, 403, 404, 4, 'data400', 405, 406);
 
 
 CREATE TABLE `link_table5_rev` (

mysql-test/suite/rocksdb/r/bypass_select_range_pk.result

@@ -358,7 +358,7 @@ id1	id2	link_type	visibility	version
 2	2	2	1	data22
 2	3	2	1	data32
 ROWS_READ
-39
+43
 COVERED_SK_LOOKUP
 0
 include/assert.inc [Verify executed in bypass]
@@ -1862,7 +1862,7 @@ id1	id2	link_type	visibility	version
 0	3	0	2	data13
 0	2	0	1	data12
 ROWS_READ
-39
+43
 COVERED_SK_LOOKUP
 0
 include/assert.inc [Verify executed in bypass]
@@ -3366,7 +3366,7 @@ id1	id2	link_type	visibility	version
 2	2	2	1	data22
 2	3	2	1	data32
 ROWS_READ
-39
+43
 COVERED_SK_LOOKUP
 0
 include/assert.inc [Verify executed in bypass]
@@ -4870,7 +4870,7 @@ id1	id2	link_type	visibility	version
 0	3	0	2	data13
 0	2	0	1	data12
 ROWS_READ
-39
+43
 COVERED_SK_LOOKUP
 0
 include/assert.inc [Verify executed in bypass]
@@ -6471,7 +6471,7 @@ id1	id2	link_type	visibility	version
 2	2	2	1	data22
 2	3	2	1	data32
 ROWS_READ
-39
+43
 COVERED_SK_LOOKUP
 0
 include/assert.inc [Verify executed in bypass]
@@ -7975,7 +7975,7 @@ id1	id2	link_type	visibility	version
 0	3	0	2	data13
 0	2	0	1	data12
 ROWS_READ
-39
+43
 COVERED_SK_LOOKUP
 0
 include/assert.inc [Verify executed in bypass]
@@ -9479,7 +9479,7 @@ id1	id2	link_type	visibility	version
 2	2	2	1	data22
 2	3	2	1	data32
 ROWS_READ
-39
+43
 COVERED_SK_LOOKUP
 0
 include/assert.inc [Verify executed in bypass]
@@ -10983,7 +10983,7 @@ id1	id2	link_type	visibility	version
 0	3	0	2	data13
 0	2	0	1	data12
 ROWS_READ
-39
+43
 COVERED_SK_LOOKUP
 0
 include/assert.inc [Verify executed in bypass]

mysql-test/suite/rocksdb/r/bypass_select_range_pk_bloom.result

@@ -358,7 +358,7 @@ id1	id2	link_type	visibility	version
 2	2	2	1	data22
 2	3	2	1	data32
 ROWS_READ
-39
+43
 COVERED_SK_LOOKUP
 0
 include/assert.inc [Verify executed in bypass]
@@ -1862,7 +1862,7 @@ id1	id2	link_type	visibility	version
 0	3	0	2	data13
 0	2	0	1	data12
 ROWS_READ
-39
+43
 COVERED_SK_LOOKUP
 0
 include/assert.inc [Verify executed in bypass]
@@ -3366,7 +3366,7 @@ id1	id2	link_type	visibility	version
 2	2	2	1	data22
 2	3	2	1	data32
 ROWS_READ
-39
+43
 COVERED_SK_LOOKUP
 0
 include/assert.inc [Verify executed in bypass]
@@ -4870,7 +4870,7 @@ id1	id2	link_type	visibility	version
 0	3	0	2	data13
 0	2	0	1	data12
 ROWS_READ
-39
+43
 COVERED_SK_LOOKUP
 0
 include/assert.inc [Verify executed in bypass]
@@ -6471,7 +6471,7 @@ id1	id2	link_type	visibility	version
 2	2	2	1	data22
 2	3	2	1	data32
 ROWS_READ
-39
+43
 COVERED_SK_LOOKUP
 0
 include/assert.inc [Verify executed in bypass]
@@ -7975,7 +7975,7 @@ id1	id2	link_type	visibility	version
 0	3	0	2	data13
 0	2	0	1	data12
 ROWS_READ
-39
+43
 COVERED_SK_LOOKUP
 0
 include/assert.inc [Verify executed in bypass]
@@ -9479,7 +9479,7 @@ id1	id2	link_type	visibility	version
 2	2	2	1	data22
 2	3	2	1	data32
 ROWS_READ
-39
+43
 COVERED_SK_LOOKUP
 0
 include/assert.inc [Verify executed in bypass]
@@ -10983,7 +10983,7 @@ id1	id2	link_type	visibility	version
 0	3	0	2	data13
 0	2	0	1	data12
 ROWS_READ
-39
+43
 COVERED_SK_LOOKUP
 0
 include/assert.inc [Verify executed in bypass]