Skip to content

Commit 3afb4bd

Browse files
sunshine-Chunfacebook-github-bot
authored andcommitted
Add rocksdb_is_supported_system_table api support for rocksdb dd (#1299)
Summary: We are adding support for data dictionary related rocksdb_hton handler functions. This will include the current diff and couple of following diffs. Each diff will add support for one or several rocksdb_hton handler function. This diff adds support for rocksdb_is_supported_system_table. Return false for now. More logic may need to be added once we have more prototype for dd bootstraping. Pull Request resolved: #1299 Test Plan: The diff will unblock the test failure in D44598701 Imported from GitHub, without a `Test Plan:` line. Reviewed By: luqun Differential Revision: D45723276 Pulled By: sunshine-Chun fbshipit-source-id: 9edee51
1 parent f421600 commit 3afb4bd

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

storage/rocksdb/ha_rocksdb.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7436,6 +7436,7 @@ static int rocksdb_init_internal(void *const p) {
74367436
rocksdb_hton->dict_register_dd_table_id = rocksdb_dict_register_dd_table_id;
74377437
rocksdb_hton->dict_get_server_version = rocksdb_dict_get_server_version;
74387438
rocksdb_hton->dict_set_server_version = rocksdb_dict_set_server_version;
7439+
rocksdb_hton->is_supported_system_table = rocksdb_is_supported_system_table;
74397440

74407441
rocksdb_hton->flags = HTON_SUPPORTS_EXTENDED_KEYS | HTON_CAN_RECREATE;
74417442

storage/rocksdb/rdb_native_dd.cc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,4 +64,8 @@ bool rocksdb_dict_set_server_version() {
6464
->set_server_version();
6565
};
6666

67+
bool rocksdb_is_supported_system_table(const char *, const char *, bool) {
68+
return false;
69+
}
70+
6771
} // namespace myrocks

storage/rocksdb/rdb_native_dd.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ namespace myrocks {
3131
void rocksdb_dict_register_dd_table_id(dd::Object_id dd_table_id);
3232
bool rocksdb_dict_get_server_version(uint *version);
3333
bool rocksdb_dict_set_server_version();
34+
bool rocksdb_is_supported_system_table(const char *, const char *, bool);
3435

3536
class native_dd {
3637
private:

0 commit comments

Comments
 (0)