Skip to content

Commit 238afbb

Browse files
rockeetfacebook-github-bot
authored andcommitted
set m_read_opts.ignore_range_deletions properly (#1218)
Summary: ignore_range_deletions should be set to true when range del is not enabled Pull Request resolved: #1218 Reviewed By: Pushapgl Differential Revision: D39115879 Pulled By: yoshinorim fbshipit-source-id: 40e7bcb
1 parent 5da4d2b commit 238afbb

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

storage/rocksdb/ha_rocksdb.cc

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4406,7 +4406,12 @@ class Rdb_transaction {
44064406
}
44074407

44084408
explicit Rdb_transaction(THD *const thd)
4409-
: m_thd(thd), m_tbl_io_perf(nullptr) {}
4409+
: m_thd(thd), m_tbl_io_perf(nullptr) {
4410+
m_read_opts[INTRINSIC_TMP].ignore_range_deletions =
4411+
!rocksdb_enable_delete_range_for_drop_index;
4412+
m_read_opts[USER_TABLE].ignore_range_deletions =
4413+
!rocksdb_enable_delete_range_for_drop_index;
4414+
}
44104415

44114416
virtual ~Rdb_transaction() {
44124417
#ifndef NDEBUG
@@ -4858,6 +4863,8 @@ class Rdb_transaction_impl : public Rdb_transaction {
48584863
m_rocksdb_reuse_tx[table_type] = nullptr;
48594864

48604865
m_read_opts[table_type] = rocksdb::ReadOptions();
4866+
m_read_opts[table_type].ignore_range_deletions =
4867+
!rocksdb_enable_delete_range_for_drop_index;
48614868

48624869
set_initial_savepoint();
48634870

@@ -4982,6 +4989,8 @@ class Rdb_writebatch_impl : public Rdb_transaction {
49824989
void reset() {
49834990
m_batch->Clear();
49844991
m_read_opts[USER_TABLE] = rocksdb::ReadOptions();
4992+
m_read_opts[USER_TABLE].ignore_range_deletions =
4993+
!rocksdb_enable_delete_range_for_drop_index;
49854994
m_ddl_transaction = false;
49864995
}
49874996

0 commit comments

Comments
 (0)