Add NoAutoLikes to HSL (1)

Summary: Many HSL functions can be given more precise types, avoiding the use of likes.

Differential Revision: D47224101

fbshipit-source-id: 517a219ef2181f8c2a013d5feb113581cd39d844

Author: Andrew Kennedy

hphp/hack/test/autocomplete/fake_arrow_dict.php.exp

@@ -109,7 +109,7 @@ Dict\associate
 Dict\cast_clear_legacy_array_mark
   INSERT Dict\cast_clear_legacy_array_mark(
   INSERT )
-  (function(KeyedTraversable<Tk, Tv> $x): ~dict<Tk, Tv>)
+  (function(KeyedTraversable<Tk, Tv> $x): dict<Tk, Tv>)
 Dict\chunk
   INSERT Dict\chunk(
   INSERT , ${1:\$size})
@@ -329,7 +329,7 @@ Str\join
 Vec\cast_clear_legacy_array_mark
   INSERT Vec\cast_clear_legacy_array_mark(
   INSERT )
-  (function(Traversable<T> $x): ~vec<T>)
+  (function(Traversable<T> $x): vec<T>)
 Vec\chunk
   INSERT Vec\chunk(
   INSERT , ${1:\$size})

hphp/hack/test/autocomplete/fake_arrow_keyset.php.exp

@@ -109,7 +109,7 @@ Dict\associate
 Dict\cast_clear_legacy_array_mark
   INSERT Dict\cast_clear_legacy_array_mark(
   INSERT )
-  (function(KeyedTraversable<Tk, Tv> $x): ~dict<Tk, Tv>)
+  (function(KeyedTraversable<Tk, Tv> $x): dict<Tk, Tv>)
 Dict\chunk
   INSERT Dict\chunk(
   INSERT , ${1:\$size})
@@ -329,7 +329,7 @@ Str\join
 Vec\cast_clear_legacy_array_mark
   INSERT Vec\cast_clear_legacy_array_mark(
   INSERT )
-  (function(Traversable<T> $x): ~vec<T>)
+  (function(Traversable<T> $x): vec<T>)
 Vec\chunk
   INSERT Vec\chunk(
   INSERT , ${1:\$size})

hphp/hack/test/autocomplete/fake_arrow_vec.php.exp

@@ -109,7 +109,7 @@ Dict\associate
 Dict\cast_clear_legacy_array_mark
   INSERT Dict\cast_clear_legacy_array_mark(
   INSERT )
-  (function(KeyedTraversable<Tk, Tv> $x): ~dict<Tk, Tv>)
+  (function(KeyedTraversable<Tk, Tv> $x): dict<Tk, Tv>)
 Dict\chunk
   INSERT Dict\chunk(
   INSERT , ${1:\$size})
@@ -325,7 +325,7 @@ Str\join
 Vec\cast_clear_legacy_array_mark
   INSERT Vec\cast_clear_legacy_array_mark(
   INSERT )
-  (function(Traversable<T> $x): ~vec<T>)
+  (function(Traversable<T> $x): vec<T>)
 Vec\chunk
   INSERT Vec\chunk(
   INSERT , ${1:\$size})

hphp/hsl/src/dict/cast.php

@@ -14,6 +14,7 @@
  * Casts the given traversable to a dict, resetting the legacy array mark
  * if applicable.
  */
+<<__NoAutoLikes>>
 function cast_clear_legacy_array_mark<Tk as arraykey, Tv>(
   KeyedTraversable<Tk, Tv> $x,
 )[]: dict<Tk, Tv> {

hphp/hsl/src/vec/cast.php

@@ -14,6 +14,7 @@
  * Casts the given traversable to a vec, resetting the legacy array mark
  * if applicable.
  */
+<<__NoAutoLikes>>
 function cast_clear_legacy_array_mark<T>(
   Traversable<T> $x,
 )[]: vec<T> {