extract shape type auto-rename

Summary:
Extract shape type refactor:
- select in IDE so the shape type is easy to rename
- Use a `T` prefix for the shape: a use told me that shape (see facebook section for why)

https://pxl.cl/2SzCZ

Reviewed By: nt591

Differential Revision: D47187718

fbshipit-source-id: f06768baec8944944bf83ba3d1f7e6faf768e7bd

Author: mheiber

hphp/hack/src/server/server_code_actions_services/extract_shape_type.ml

@@ -90,7 +90,7 @@ let edit_of_candidate ~path { shape_ty; container_pos; tast_env } :
     in
     let tenv = Tast_env.tast_env_as_typing_env tast_env in
     let ty_text = Typing_print.full_strip_ns tenv shape_ty in
-    let text = Printf.sprintf "type placeholder_ = %s;\n\n" ty_text in
+    let text = Printf.sprintf "type T${0:placeholder_} = %s;\n\n" ty_text in
     Lsp.TextEdit.{ range; newText = text }
   in
   let changes = SMap.singleton (Relative_path.to_absolute path) [edit] in

hphp/hack/test/ide_code_actions/extract_shape_type/extract_shape_type_1.php.exp

@@ -11,7 +11,7 @@ JSON for selected code action:
     "changes":{
       "FILE.php":[
         {
-          "newText":"type placeholder_ = shape('a' => int, 'b' => A);\n\n",
+          "newText":"type T${0:placeholder_} = shape('a' => int, 'b' => A);\n\n",
           "range":{"end":{"character":0,"line":5},"start":{"character":0,"line":5}}
         }
       ]
@@ -28,7 +28,7 @@ Applied edit for code action:
 class Other {}
 class A {}
 
-type placeholder_ = shape('a' => int, 'b' => A);
+type T${0:placeholder_} = shape('a' => int, 'b' => A);
 
 function foo(): void {
   $a = new A();

hphp/hack/test/ide_code_actions/extract_shape_type/extract_shape_type_2.php.exp

@@ -12,7 +12,7 @@ JSON for selected code action:
     "changes":{
       "FILE.php":[
         {
-          "newText":"type placeholder_ = shape('a' => int, 'b' => A);\n\n",
+          "newText":"type T${0:placeholder_} = shape('a' => int, 'b' => A);\n\n",
           "range":{"end":{"character":0,"line":4},"start":{"character":0,"line":4}}
         }
       ]
@@ -28,7 +28,7 @@ Applied edit for code action:
 
 class A {}
 
-type placeholder_ = shape('a' => int, 'b' => A);
+type T${0:placeholder_} = shape('a' => int, 'b' => A);
 
 class C {
   public function foo(): void {

hphp/hack/test/ide_code_actions/extract_shape_type/extract_shape_type_3.php.exp

@@ -12,7 +12,7 @@ JSON for selected code action:
     "changes":{
       "FILE.php":[
         {
-          "newText":"type placeholder_ = shape();\n\n",
+          "newText":"type T${0:placeholder_} = shape();\n\n",
           "range":{"end":{"character":0,"line":2},"start":{"character":0,"line":2}}
         }
       ]
@@ -26,7 +26,7 @@ Applied edit for code action:
 ------------------------------------------
 <?hh
 
-type placeholder_ = shape();
+type T${0:placeholder_} = shape();
 
 class C {
   public function foo(): void {

hphp/hack/test/ide_code_actions/extract_shape_type/extract_shape_type_4.php.exp

@@ -12,7 +12,7 @@ JSON for selected code action:
     "changes":{
       "FILE.php":[
         {
-          "newText":"type placeholder_ = shape('the_union' => (int | bool));\n\n",
+          "newText":"type T${0:placeholder_} = shape('the_union' => (int | bool));\n\n",
           "range":{"end":{"character":0,"line":2},"start":{"character":0,"line":2}}
         }
       ]
@@ -26,7 +26,7 @@ Applied edit for code action:
 ------------------------------------------
 <?hh
 
-type placeholder_ = shape('the_union' => (int | bool));
+type T${0:placeholder_} = shape('the_union' => (int | bool));
 
 class C {
   public function foo(): void {

hphp/hack/test/ide_code_actions/extract_shape_type/extract_shape_type_5.php.exp

@@ -12,7 +12,7 @@ JSON for selected code action:
     "changes":{
       "FILE.php":[
         {
-          "newText":"type placeholder_ = shape('a' => nothing);\n\n",
+          "newText":"type T${0:placeholder_} = shape('a' => nothing);\n\n",
           "range":{"end":{"character":0,"line":2},"start":{"character":0,"line":2}}
         }
       ]
@@ -26,7 +26,7 @@ Applied edit for code action:
 ------------------------------------------
 <?hh
 
-type placeholder_ = shape('a' => nothing);
+type T${0:placeholder_} = shape('a' => nothing);
 
 class C {
   public function foo(): void {

hphp/hack/test/ide_code_actions/extract_shape_type/extract_shape_type_6.php.exp

@@ -12,7 +12,7 @@ JSON for selected code action:
     "changes":{
       "FILE.php":[
         {
-          "newText":"type placeholder_ = shape('a' => int);\n\n",
+          "newText":"type T${0:placeholder_} = shape('a' => int);\n\n",
           "range":{"end":{"character":0,"line":2},"start":{"character":0,"line":2}}
         }
       ]
@@ -26,7 +26,7 @@ Applied edit for code action:
 ------------------------------------------
 <?hh
 
-type placeholder_ = shape('a' => int);
+type T${0:placeholder_} = shape('a' => int);
 
 class C {
   public function foo(vec<int> $v): void {

hphp/hack/test/ide_code_actions/extract_shape_type/extract_shape_type_7.php.exp

@@ -12,7 +12,7 @@ JSON for selected code action:
     "changes":{
       "FILE.php":[
         {
-          "newText":"type placeholder_ = shape('a' => shape('b' => vec<int>));\n\n",
+          "newText":"type T${0:placeholder_} = shape('a' => shape('b' => vec<int>));\n\n",
           "range":{"end":{"character":0,"line":2},"start":{"character":0,"line":2}}
         }
       ]
@@ -26,7 +26,7 @@ Applied edit for code action:
 ------------------------------------------
 <?hh
 
-type placeholder_ = shape('a' => shape('b' => vec<int>));
+type T${0:placeholder_} = shape('a' => shape('b' => vec<int>));
 
 class C {
   public function foo(vec<int> $v): void {

hphp/hack/test/ide_code_actions/extract_shape_type/extract_shape_type_like_types.php.exp

@@ -11,7 +11,7 @@ JSON for selected code action:
     "changes":{
       "FILE.php":[
         {
-          "newText":"type placeholder_ = shape('a' => int);\n\n",
+          "newText":"type T${0:placeholder_} = shape('a' => int);\n\n",
           "range":{"end":{"character":0,"line":2},"start":{"character":0,"line":2}}
         }
       ]
@@ -25,7 +25,7 @@ Applied edit for code action:
 ------------------------------------------
 <?hh
 
-type placeholder_ = shape('a' => int);
+type T${0:placeholder_} = shape('a' => int);
 
 function foo(vec<shape('a' => int)> $v): void {
   $sh = $v[0];

hphp/hack/test/ide_code_actions/extract_shape_type/extract_shape_type_var_1.php.exp

@@ -12,7 +12,7 @@ JSON for selected code action:
     "changes":{
       "FILE.php":[
         {
-          "newText":"type placeholder_ = shape(?'a' => int, 'b' => int, ...);\n\n",
+          "newText":"type T${0:placeholder_} = shape(?'a' => int, 'b' => int, ...);\n\n",
           "range":{"end":{"character":0,"line":2},"start":{"character":0,"line":2}}
         }
       ]
@@ -26,7 +26,7 @@ Applied edit for code action:
 ------------------------------------------
 <?hh
 
-type placeholder_ = shape(?'a' => int, 'b' => int, ...);
+type T${0:placeholder_} = shape(?'a' => int, 'b' => int, ...);
 
 class C {
   public function foo(shape(?"a" => int, ...) $sh): void {