Fixes for advanced_unstable_linking

Summary:
A few fixes in order to make advanced_unstable_linking work, a few fixes were needed to handle compiling + linking rust code.

1. Make sure hollow rlibs are always generated for metadata-full emits.
2. Make sure that the targets themselves are added as dependencies when using advanced_unstable_linking.
3. Apply a workaround for version scripts related to latest clang + building dylibs.

Reviewed By: diliop

Differential Revision: D58169850

fbshipit-source-id: 15b675b3ae35ea0b00c279f47e4c9a701e990eb6

Author: capickett

prelude/rust/build.bzl

@@ -435,6 +435,16 @@ def rust_compile(
 
     lints, clippy_lints = _lint_flags(compile_ctx)
 
+    # If we are building metadata-full for a dylib target, we want the hollow-rlib version of rmeta, not the shared lib version.
+    if compile_ctx.dep_ctx.advanced_unstable_linking and emit == Emit("metadata-full") and params.crate_type == CrateType("dylib"):
+        params = BuildParams(
+            crate_type = CrateType("rlib"),
+            reloc_model = params.reloc_model,
+            dep_link_strategy = params.dep_link_strategy,
+            prefix = "lib",
+            suffix = ".rlib",
+        )
+
     common_args = _compute_common_args(
         ctx = ctx,
         compile_ctx = compile_ctx,

prelude/rust/link_info.bzl

@@ -201,6 +201,7 @@ RustOrNativeDependency = record(
 RustDependency = record(
     info = field(RustLinkInfo),
     label = field(ConfiguredProvidersLabel),
+    dep = field(Dependency),
     name = field([None, str]),
     flags = field(list[str]),
     proc_macro_marker = field([None, RustProcMacroMarker]),
@@ -343,6 +344,7 @@ def resolve_rust_deps_inner(
         rust_deps.append(RustDependency(
             info = info,
             label = label,
+            dep = dep.dep,
             name = dep.name,
             flags = dep.flags,
             proc_macro_marker = proc_macro_marker,
@@ -389,9 +391,15 @@ def inherited_exported_link_deps(ctx: AnalysisContext, dep_ctx: DepCollectionCon
     deps = {}
     for dep in _native_link_dependencies(ctx, dep_ctx):
         deps[dep.label] = dep
-    for info in _rust_non_proc_macro_link_infos(ctx, dep_ctx):
-        for dep in info.exported_link_deps:
+    for dep in resolve_rust_deps(ctx, dep_ctx):
+        if dep.proc_macro_marker != None:
+            continue
+
+        if dep_ctx.advanced_unstable_linking:
+            deps[dep.label] = dep.dep
+        for dep in dep.info.exported_link_deps:
             deps[dep.label] = dep
+
     return deps.values()
 
 def inherited_rust_cxx_link_group_info(