Fixed linter issues (#71)

Author: f3ath

analysis_options.yaml

@@ -0,0 +1 @@
+include: package:pedantic/analysis_options.yaml

example/cars_server.dart

@@ -4,6 +4,7 @@ import 'dart:io';
 import 'package:json_api/server.dart';
 import 'package:json_api/src/server/server_document_factory.dart';
 import 'package:json_api/url_design.dart';
+import 'package:pedantic/pedantic.dart';
 
 import 'cars_server/controller.dart';
 import 'cars_server/dao.dart';
@@ -63,6 +64,6 @@ Future<HttpServer> createServer(InternetAddress addr, int port) async {
       ServerDocumentFactory(urlDesign, pagination: pagination);
   final jsonApiServer = JsonApiServer(urlDesign, controller, documentFactory);
 
-  httpServer.forEach(jsonApiServer.serve);
+  unawaited(httpServer.forEach(jsonApiServer.serve));
   return httpServer;
 }

example/cars_server/controller.dart

@@ -205,6 +205,6 @@ class CarsController implements JsonApiController {
     return resource;
   }
 
-  Map<T, R> _filter<T, R>(Map<T, R> map, bool f(T t)) =>
+  Map<T, R> _filter<T, R>(Map<T, R> map, bool Function(T t) f) =>
       {...map}..removeWhere((k, _) => !f(k));
 }

example/cars_server/dao.dart

@@ -49,11 +49,14 @@ abstract class DAO<T> {
 }
 
 class ModelDAO extends DAO<Model> {
+  @override
   Resource toResource(Model _) =>
       Resource('models', _.id, attributes: {'name': _.name});
 
+  @override
   void insert(Model model) => _collection[model.id] = model;
 
+  @override
   Model create(Resource r) {
     return Model(r.id)..name = r.attributes['name'];
   }
@@ -66,17 +69,21 @@ class ModelDAO extends DAO<Model> {
 }
 
 class CityDAO extends DAO<City> {
+  @override
   Resource toResource(City _) =>
       Resource('cities', _.id, attributes: {'name': _.name});
 
+  @override
   void insert(City city) => _collection[city.id] = city;
 
+  @override
   City create(Resource r) {
     return City(r.id)..name = r.attributes['name'];
   }
 }
 
 class CompanyDAO extends DAO<Company> {
+  @override
   Resource toResource(Company company) =>
       Resource('companies', company.id, attributes: {
         'name': company.name,
@@ -90,11 +97,13 @@ class CompanyDAO extends DAO<Company> {
         'models': company.models.map((_) => Identifier('models', _)).toList()
       });
 
+  @override
   void insert(Company company) {
     company.updatedAt = DateTime.now();
     _collection[company.id] = company;
   }
 
+  @override
   Company create(Resource r) {
     return Company(r.id)
       ..name = r.attributes['name']
@@ -104,7 +113,7 @@ class CompanyDAO extends DAO<Company> {
   @override
   int deleteById(String id) {
     final company = fetchById(id);
-    int deps = company.headquarters == null ? 0 : 1;
+    var deps = company.headquarters == null ? 0 : 1;
     deps += company.models.length;
     _collection.remove(id);
     return deps;

example/cars_server/job_queue.dart

@@ -10,6 +10,6 @@ class Job {
   Resource resource;
 
   Job(Future<Resource> create) : id = Uuid().v4() {
-    create.then((_) => this.resource = _);
+    create.then((_) => resource = _);
   }
 }

example/cars_server/model.dart

@@ -1,7 +1,7 @@
 class Company {
   final String id;
   String headquarters;
-  final models = Set<String>();
+  final models = <String>{};
 
   /// Company name
   String name;

lib/src/client/json_api_client.dart

@@ -195,7 +195,7 @@ class JsonApiClient {
         ..body = json.encode(doc);
 
   Future<Response<D>> _call<D extends PrimaryData>(
-      http.Request request, D decodePrimaryData(Object _)) async {
+      http.Request request, D Function(Object _) decodePrimaryData) async {
     final response =
         await http.Response.fromStream(await httpClient.send(request));
     _onHttpCall(request, response);
@@ -217,6 +217,7 @@ class JsonApiClient {
 
 /// Defines the hook which gets called when the HTTP response is received from
 /// the HTTP Client.
-typedef void OnHttpCall(http.Request request, http.Response response);
+typedef OnHttpCall = void Function(
+    http.Request request, http.Response response);
 
-_doNothing(http.Request request, http.Response response) {}
+void _doNothing(http.Request request, http.Response response) {}

lib/src/document/api.dart

@@ -9,7 +9,7 @@ class Api {
   final Map<String, Object> meta;
 
   Api({this.version, Map<String, Object> meta})
-      : this.meta = meta == null ? null : Map.unmodifiable(meta);
+      : meta = meta == null ? null : Map.unmodifiable(meta);
 
   static Api fromJson(Object json) {
     if (json is Map) {

lib/src/document/document.dart

@@ -20,27 +20,27 @@ class Document<Data extends PrimaryData> {
 
   /// Create a document with primary data
   Document(this.data, {Map<String, Object> meta, this.api})
-      : this.errors = null,
-        this.meta = (meta == null) ? null : Map.unmodifiable(meta);
+      : errors = null,
+        meta = (meta == null) ? null : Map.unmodifiable(meta);
 
   /// Create a document with errors (no primary data)
   Document.error(Iterable<JsonApiError> errors,
       {Map<String, Object> meta, this.api})
-      : this.data = null,
-        this.meta = (meta == null) ? null : Map.unmodifiable(meta),
-        this.errors = List.unmodifiable(errors);
+      : data = null,
+        meta = (meta == null) ? null : Map.unmodifiable(meta),
+        errors = List.unmodifiable(errors);
 
   /// Create an empty document (no primary data and no errors)
   Document.empty(Map<String, Object> meta, {this.api})
-      : this.data = null,
-        this.meta = (meta == null) ? null : Map.unmodifiable(meta),
-        this.errors = null {
+      : data = null,
+        meta = (meta == null) ? null : Map.unmodifiable(meta),
+        errors = null {
     ArgumentError.checkNotNull(meta, 'meta');
   }
 
   /// Reconstructs a document with the specified primary data
   static Document<Data> fromJson<Data extends PrimaryData>(
-      Object json, Data primaryData(Object json)) {
+      Object json, Data Function(Object json) primaryData) {
     if (json is Map) {
       Api api;
       if (json.containsKey('jsonapi')) {

lib/src/document/identifier.dart

@@ -23,5 +23,6 @@ class Identifier {
       other.type == type &&
       other.id == id;
 
-  String toString() => "Identifier($type:$id)";
+  @override
+  String toString() => 'Identifier($type:$id)';
 }