fix: stderr being emitted in binary mode

Author: Almenon

index.ts

@@ -37,6 +37,9 @@ function getRandomInt(){
 }
 
 export interface Options extends SpawnOptions{
+    /**
+     * if binary is enabled message and stderr events will not be emitted
+     */
     mode?: 'text'|'json'|'binary'
     formatter?: (param:string)=>any
     parser?: (param:string)=>any
@@ -147,7 +150,7 @@ export class PythonShell extends EventEmitter{
         }
 
         // listen to stderr and emit errors for incoming data
-        if (this.stderr) {
+        if (this.stderrParser && this.stderr) {
             this.stderr.on('data', function (data) {
                 errorData += ''+data;
                 self.receiveStderr(data);

test/test-python-shell.ts

@@ -348,7 +348,8 @@ describe('PythonShell', function () {
                 mode: 'binary'
             });
             pyshell.receive = function () {
-                throw new Error('should not emit messages in binary mode');
+                done('should not emit messages in binary mode');
+                return undefined
             };
             pyshell.end(done);
         });
@@ -385,12 +386,12 @@ describe('PythonShell', function () {
             }).send('hello').send('world').end(done);
         });
         it('should not be invoked when mode is "binary"', function (done) {
-            let pyshell = new PythonShell('echo_args.py', {
-                args: ['hello', 'world'],
+            let pyshell = new PythonShell('stderrLogging.py', {
                 mode: 'binary'
             });
             pyshell.receiveStderr = function () {
-                throw new Error('should not emit stderr in binary mode');
+                done('should not emit stderr in binary mode');
+                return undefined
             };
             pyshell.end(done);
         });