Skip to content

Commit 7736baf

Browse files
Merge pull request #109 from express-vue/develop
updating master
2 parents 1e24af1 + 43186d2 commit 7736baf

File tree

6 files changed

+156
-70
lines changed

6 files changed

+156
-70
lines changed

package-lock.json

Lines changed: 100 additions & 64 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,11 +103,11 @@
103103
"eslint-config-xo-space": "^0.17.0",
104104
"eslint-plugin-flowtype": "^2.36.0",
105105
"express": "^4.16.0",
106-
"flow-bin": "^0.57.1",
106+
"flow-bin": "^0.58.0",
107107
"flow-remove-types": "^1.2.1",
108108
"generate-release": "^0.14.0",
109109
"nodemon": "^1.12.1",
110-
"nsp": "^2.8.1",
110+
"nsp": "^3.0.0",
111111
"nyc": "^11.2.1",
112112
"uuid": "^3.1.0"
113113
}

src/utils/head.js

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,18 @@ class HeadUtil {
3333
}
3434
if (vueObject.head && vueObject.head.meta) {
3535
for (let metaItem of vueObject.head.meta) {
36-
if (metaItem.name) {
36+
if (metaItem.value) {
37+
this.metaTags += `<meta name="${metaItem.name}" value="${metaItem.value}"/>\n`;
38+
} else if (metaItem.name) {
3739
this.metaTags += `<meta name="${metaItem.name}" content="${metaItem.content}"/>\n`;
3840
} else if (metaItem.property) {
3941
this.metaTags += `<meta property="${metaItem.property}" content="${metaItem.content}"/>\n`;
4042
} else if (metaItem.script) {
4143
const charset = metaItem.charset || 'utf-8';
4244
const async = metaItem.async ? ' async=true' : '';
4345
this.metaTags += `<script src="${metaItem.script}" charset="${charset}"${async}></script>\n`;
46+
} else if (metaItem.charset) {
47+
this.metaTags += `<meta charset="${metaItem.charset}"/>\n`;
4448
} else if (metaItem.style) {
4549
const type = metaItem.type || 'text/css';
4650
const rel = 'stylesheet';
@@ -51,7 +55,10 @@ class HeadUtil {
5155
const type = metaItem.type ? `type="${metaItem.type}" ` : '';
5256
const href = metaItem.href ? `href="${metaItem.href}" ` : '';
5357
const sizes = metaItem.sizes ? `sizes="${metaItem.sizes}" ` : '';
54-
this.metaTags += `<link ${rel}${type}${href}${sizes}>\n`;
58+
const itemprop = metaItem.itemprop ? `itemprop="${metaItem.itemprop}" ` : '';
59+
const hreflang = metaItem.hreflang ? `hreflang="${metaItem.hreflang}" ` : '';
60+
const crossorigin = metaItem.crossorigin ? `crossorigin="${metaItem.crossorigin}"` : '';
61+
this.metaTags += `<link ${rel}${type}${href}${sizes}${itemprop}${hreflang}${crossorigin}>\n`;
5562
} else if (metaItem.srcContents) {
5663
this.metaTags += `${metaItem.srcContents}\n`;
5764
}

tests/example/app.js

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,20 @@ const options = {
3131
}, {
3232
name: 'viewport',
3333
content: 'width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no'
34+
},
35+
{
36+
rel: 'preconnect',
37+
href: 'http://www.example.com',
38+
itemprop: 'url',
39+
hreflang: 'en',
40+
crossorigin: 'anonymous'
41+
},
42+
{
43+
name: 'google',
44+
value: 'notranslate'
45+
},
46+
{
47+
charset: 'UTF-8'
3448
}
3549
]
3650
}

tests/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,4 +66,4 @@ test('renders App object with custom layout', t => {
6666
.catch(error => {
6767
t.fail(error.stack);
6868
});
69-
});
69+
});

0 commit comments

Comments
 (0)