fix(vm): show func for safe calls in disassembly #869
+31
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, safe builtin functions (OpCallSafe) were pushed to the stack as constants (OpPush), causing the disassembler/debugger to display their memory address (e.g., 0x140000...) instead of their name (e.g., concat). This change updates the compiler to store the function name in debugInfo when emitting OpCallSafe. The VM's disassembler now checks debugInfo for OpPush arguments and displays the stored name if available. Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, safe builtin functions (OpCallSafe) were pushed to the stack as constants (OpPush), causing the disassembler/debugger to display their memory address (e.g., 0x140000...) instead of their name (e.g., concat). This change updates the compiler to store the function name in debugInfo when emitting OpCallSafe.
Output from repl:
Fixes #567.