Skip to content

Commit 8f8b767

Browse files
Merge pull request #3 from eugene-matvejev/init-files
fix ::removeBytes concept
2 parents 895f9a2 + 6aba20e commit 8f8b767

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

src/byte_flag_calculator.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ module.exports = class ByteFlagCalculator {
88
}
99

1010
static removeBytes(flags, flag) {
11-
return ByteFlagCalculator.hasBytes(flags, flag)
12-
? flags & ~flag
13-
: flags;
11+
return flags & ~flag;
1412
}
1513
};

tests/byte_flag_calculator.test.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,10 @@ describe(`byte flag calculator`, () => {
4848
{ flags: 0x02, flag: 0x01, expected: 0x02 },
4949
{ flags: 0x12, flag: 0x02, expected: 0x10 },
5050
{ flags: 0x04, flag: 0x04, expected: 0x00 },
51-
{ flags: 0x0F, flag: 0xFF, expected: 0x0F },
51+
{ flags: 0x02, flag: 0x04, expected: 0x02 },
52+
{ flags: 0xFF, flag: 0xFF, expected: 0x00 },
53+
{ flags: 0xFF, flag: 0x0F, expected: 0xF0 },
54+
{ flags: 0xFF, flag: 0xF0, expected: 0x0F },
5255
].forEach(el => {
5356
it(` - expected ${el.expected} by removing bytes ${el.flag} from ${el.flags}`, () => {
5457
expect(calc.removeBytes(el.flags, el.flag)).toBe(el.expected);

0 commit comments

Comments
 (0)